Right now, PolicyDecisionSender sends 5 parameters. This should be refactored into sending a single struct parameter which contains these values.
<rdar://problem/59590676>
Created attachment 391163 [details] Patch
Comment on attachment 391163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391163&action=review > Source/WebKit/Shared/PolicyDecisionData.h:37 > + uint64_t navigationID; These should have default initializers so we don't accidentally use uninitialized memory. uint64_t navigationID { 0 }; etc.
Comment on attachment 391163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391163&action=review > Source/WebKit/Shared/PolicyDecisionData.h:34 > +struct PolicyDecisionData { Can we call this struct just "PolicyDecision"? All classes are data, so "Data" doesn't add meaning here. ("Info" is another words folks are often tempted to use, which I recommend against.) I also prefer how "send(PolicyDecision {... })" reads like a complete statement: "I am sending a policy decision."
Yes, I'll change both of these before landing. Thanks!
Created attachment 391187 [details] Patch for landing
Comment on attachment 391187 [details] Patch for landing Clearing flags on attachment: 391187 Committed r256934: <https://trac.webkit.org/changeset/256934>
All reviewed patches have been landed. Closing bug.