Bug 207936 – WebPageProxy::PolicyDecisionSender should send a struct instead of many parameters

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kate Cheney]

Right now, PolicyDecisionSender sends 5 parameters. This should be refactored into sending a single struct parameter which contains these values.

[Radar WebKit Bug Importer]

<rdar://problem/59590676>

[Kate Cheney]

Created attachment 391163 [details]
Patch

[Alex Christensen]

Comment on attachment 391163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391163&action=review

> Source/WebKit/Shared/PolicyDecisionData.h:37
> +    uint64_t navigationID;

These should have default initializers so we don't accidentally use uninitialized memory.
uint64_t navigationID { 0 };
etc.

[Geoffrey Garen]

Comment on attachment 391163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391163&action=review

> Source/WebKit/Shared/PolicyDecisionData.h:34
> +struct PolicyDecisionData {

Can we call this struct just "PolicyDecision"? All classes are data, so "Data" doesn't add meaning here. ("Info" is another words folks are often tempted to use, which I recommend against.)

I also prefer how "send(PolicyDecision {... })" reads like a complete statement: "I am sending a policy decision."

[Kate Cheney]

Yes, I'll change both of these before landing. Thanks!

[Kate Cheney]

Created attachment 391187 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 391187 [details]
Patch for landing

Clearing flags on attachment: 391187

Committed r256934: <https://trac.webkit.org/changeset/256934>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.