Bug 207930 - [Curl] Simplify Cookie class.
Summary: [Curl] Simplify Cookie class.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-19 01:26 PST by Takashi Komori
Modified: 2020-02-20 12:07 PST (History)
16 users (show)

See Also:

Attachments
Remove redundant CookieJarCurl.cpp (28.96 KB, patch)
2020-02-19 01:36 PST, Takashi Komori 		no flags Details | Formatted Diff | Diff
Patch (32.97 KB, patch)
2020-02-19 23:16 PST, Takashi Komori 		no flags Details | Formatted Diff | Diff
Patch (32.97 KB, patch)
2020-02-19 23:47 PST, Takashi Komori 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Takashi Komori 2020-02-19 01:26:18 PST 
In this ticket we will remove redundant implementation in curl Cookie classes.
Comment 1 Takashi Komori 2020-02-19 01:36:59 PST 
Created attachment 391148 [details]
Remove redundant CookieJarCurl.cpp
Comment 2 Basuke Suzuki 2020-02-19 10:23:45 PST 
Comment on attachment 391148 [details]
Remove redundant CookieJarCurl.cpp

This is informal review: Please add a simple description of this fix. AFAIK, Curl implementation has an abstraction of cookie backend such as file-based, sqlite-based. This is a left over of those abstraction when file-based implementation was removed.
Comment 3 Takashi Komori 2020-02-19 23:16:07 PST 
Created attachment 391265 [details]
Patch
Comment 4 Takashi Komori 2020-02-19 23:47:14 PST 
Created attachment 391266 [details]
Patch
Comment 5 WebKit Commit Bot 2020-02-20 12:06:58 PST 
Comment on attachment 391266 [details]
Patch

Clearing flags on attachment: 391266

Committed r257078: <https://trac.webkit.org/changeset/257078>
Comment 6 WebKit Commit Bot 2020-02-20 12:07:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-02-20 12:07:17 PST 
<rdar://problem/59638605>