Bug 207924 - Reduce use of PlatformMediaSessionManager::sharedManager()
Summary: Reduce use of PlatformMediaSessionManager::sharedManager()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-18 16:48 PST by youenn fablet
Modified: 2020-02-18 20:51 PST (History)
13 users (show)

See Also:

Attachments
Patch (2.37 KB, patch)
2020-02-18 16:48 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (13.85 KB, patch)
2020-02-18 17:18 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-02-18 16:48:08 PST 
Make PlatformMediaSession constructor protected
Comment 1 youenn fablet 2020-02-18 16:48:49 PST 
Created attachment 391120 [details]
Patch
Comment 2 youenn fablet 2020-02-18 17:14:35 PST 
Let's squash the current patch with "Reduce use of PlatformMediaSessionManager::sharedManager()"
Comment 3 youenn fablet 2020-02-18 17:18:22 PST 
Created attachment 391121 [details]
Patch
Comment 4 WebKit Commit Bot 2020-02-18 20:50:04 PST 
The commit-queue encountered the following flaky tests while processing attachment 391121 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2020-02-18 20:50:35 PST 
Comment on attachment 391121 [details]
Patch

Clearing flags on attachment: 391121

Committed r256904: <https://trac.webkit.org/changeset/256904>
Comment 6 WebKit Commit Bot 2020-02-18 20:50:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-02-18 20:51:16 PST 
<rdar://problem/59578412>