Bug 207918 - EWS should be able to search existing bugs for given test
Summary: EWS should be able to search existing bugs for given test
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks: 207935
  Show dependency treegraph
 
Reported: 2020-02-18 15:26 PST by Aakash Jain
Modified: 2020-02-19 08:42 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.04 KB, patch)
2020-02-18 15:27 PST, Aakash Jain
jbedard: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-02-18 15:26:01 PST
EWS should be able to search existing bugs for given test. This is required so that EWS can decide whether or not to file new bug for flaky test (for commit-queue).
Comment 1 Aakash Jain 2020-02-18 15:27:14 PST
Created attachment 391106 [details]
Patch
Comment 2 Aakash Jain 2020-02-18 15:30:04 PST
Comment on attachment 391106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391106&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:498
> +    def fetch_bug_id_for_flaky_test(self, flaky_test_name):

Inspired from _lookup_bug_for_flaky_test  https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/tool/bot/flakytestreporter.py#L70
Comment 3 Jonathan Bedard 2020-02-18 16:18:16 PST
Before landing this, I think we should have a discussion about if this actually the right way to achieve our goals.

We had an offline discussion about this today, I wonder if we should start with an umbrella bug with the problem statement and more formally determine which solution we want before implementing a solution.
Comment 4 Aakash Jain 2020-02-19 07:45:04 PST
This is required to migrate the existing functionality of commit-queue from old ews to new ews (irrespective of whether we decide for other EWS queue to automatically file bugs for flaky tests or not).

I believe there isn't a disagreement about commit-queue filing bugs for flaky tests.
Comment 5 Jonathan Bedard 2020-02-19 08:42:59 PST
(In reply to Aakash Jain from comment #4)
> This is required to migrate the existing functionality of commit-queue from
> old ews to new ews (irrespective of whether we decide for other EWS queue to
> automatically file bugs for flaky tests or not).
> 
> I believe there isn't a disagreement about commit-queue filing bugs for
> flaky tests.

Didn't realize we have commit queue doing this now.