Bug 207914 - [PlayStation] Get jsc test wrappers using find_package
Summary: [PlayStation] Get jsc test wrappers using find_package
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-18 15:07 PST by Stephan Szabo
Modified: 2020-02-19 11:47 PST (History)
13 users (show)

See Also:


Attachments
Patch (1.80 KB, patch)
2020-02-19 10:59 PST, Stephan Szabo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2020-02-18 15:07:26 PST
Right now JSC is getting the playstation specific test wrappers for the shell via find_library and some manual setting of wrappers that become --Wl,--wrap= arguments. This has the problem that when adding wrappers that call the real function, the shell fails to build until the cmake is changed.

Downstream, we've moved to using find_package and having the library provide the correct arguments and dependencies via a config cmake.
Comment 1 Stephan Szabo 2020-02-19 10:59:35 PST
Created attachment 391178 [details]
Patch
Comment 2 WebKit Commit Bot 2020-02-19 11:46:19 PST
Comment on attachment 391178 [details]
Patch

Clearing flags on attachment: 391178

Committed r256930: <https://trac.webkit.org/changeset/256930>
Comment 3 WebKit Commit Bot 2020-02-19 11:46:21 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-02-19 11:47:15 PST
<rdar://problem/59599495>