Bug 207912 - Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
Summary: Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-18 15:00 PST by Alex Christensen
Modified: 2020-02-18 15:49 PST (History)
4 users (show)

See Also:

Attachments
Patch (12.77 KB, patch)
2020-02-18 15:03 PST, Alex Christensen 		bweinstein: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-02-18 15:00:03 PST 
Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
Comment 1 Alex Christensen 2020-02-18 15:03:03 PST 
Created attachment 391097 [details]
Patch
Comment 2 Brian Weinstein 2020-02-18 15:43:19 PST 
Comment on attachment 391097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391097&action=review

> Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm:153
> +        case 'S': {

Can these two cases be the same?

case ’s’:
case ’S’:
    …

> Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm:366
> +    // char

Nit: // unsigned char..
Comment 3 Alex Christensen 2020-02-18 15:44:37 PST 
Comment on attachment 391097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391097&action=review

>> Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm:153
>> +        case 'S': {
> 
> Can these two cases be the same?
> 
> case ’s’:
> case ’S’:
>     …

No, but one of my "short value;" should be "unsigned short value;"
Will fix when landing.
Comment 4 Alex Christensen 2020-02-18 15:48:33 PST 
http://trac.webkit.org/r256867
Comment 5 Radar WebKit Bug Importer 2020-02-18 15:49:20 PST 
<rdar://problem/59569734>