Bug 207910 – results.webkit.org: Correctly report JSC tests for windows

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

We aren't setting the version number and version name for JSC testing correctly.

[Jonathan Bedard]

Created attachment 391092 [details]
Patch

[Aakash Jain]

Comment on attachment 391092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391092&action=review

rs=me

> Tools/Scripts/webkitdirs.pm:1372
> +    $versionString =~ /(\d+)\.(\d+)\.(\d+)/;

what does versionString looks like on windows?

[Jonathan Bedard]

(In reply to Aakash Jain from comment #2)
> Comment on attachment 391092 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=391092&action=review
> 
> rs=me
> 
> > Tools/Scripts/webkitdirs.pm:1372
> > +    $versionString =~ /(\d+)\.(\d+)\.(\d+)/;
> 
> what does versionString looks like on windows?

10.0.12345

Obviously that last part isn't accurate, but it is a large 4-5 digit number.

[Jonathan Bedard]

Created attachment 391160 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 391160 [details]:

http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 391160 [details]
Patch for landing

Clearing flags on attachment: 391160

Committed r256920: <https://trac.webkit.org/changeset/256920>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59591455>

[Jonathan Bedard]

Committed r257058: <https://trac.webkit.org/changeset/257058>