Bug 207910 - results.webkit.org: Correctly report JSC tests for windows
Summary: results.webkit.org: Correctly report JSC tests for windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-18 14:05 PST by Jonathan Bedard
Modified: 2020-02-20 07:27 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.77 KB, patch)
2020-02-18 14:22 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (1.74 KB, patch)
2020-02-19 07:38 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-02-18 14:05:44 PST 
We aren't setting the version number and version name for JSC testing correctly.
Comment 1 Jonathan Bedard 2020-02-18 14:22:57 PST 
Created attachment 391092 [details]
Patch
Comment 2 Aakash Jain 2020-02-18 14:26:05 PST 
Comment on attachment 391092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391092&action=review

rs=me

> Tools/Scripts/webkitdirs.pm:1372
> +    $versionString =~ /(\d+)\.(\d+)\.(\d+)/;

what does versionString looks like on windows?
Comment 3 Jonathan Bedard 2020-02-18 14:47:53 PST 
(In reply to Aakash Jain from comment #2)
> Comment on attachment 391092 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=391092&action=review
> 
> rs=me
> 
> > Tools/Scripts/webkitdirs.pm:1372
> > +    $versionString =~ /(\d+)\.(\d+)\.(\d+)/;
> 
> what does versionString looks like on windows?

10.0.12345

Obviously that last part isn't accurate, but it is a large 4-5 digit number.
Comment 4 Jonathan Bedard 2020-02-19 07:38:50 PST 
Created attachment 391160 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2020-02-19 08:37:04 PST 
The commit-queue encountered the following flaky tests while processing attachment 391160 [details]:

http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: dbates@webkit.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-02-19 08:37:40 PST 
Comment on attachment 391160 [details]
Patch for landing

Clearing flags on attachment: 391160

Committed r256920: <https://trac.webkit.org/changeset/256920>
Comment 7 WebKit Commit Bot 2020-02-19 08:37:41 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-02-19 08:39:07 PST 
<rdar://problem/59591455>
Comment 9 Jonathan Bedard 2020-02-20 07:27:52 PST 
Committed r257058: <https://trac.webkit.org/changeset/257058>