Bug 207908 - Regression(r246188) WebProcess is launched too eagerly when [WKWebView _restoreSessionState] is called
Summary: Regression(r246188) WebProcess is launched too eagerly when [WKWebView _resto...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 208024 211626
Blocks: 198561
  Show dependency treegraph
 
Reported: 2020-02-18 13:17 PST by Chris Dumez
Modified: 2020-05-08 08:42 PDT (History)
8 users (show)

See Also:


Attachments
Patch (7.21 KB, patch)
2020-02-18 13:24 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (7.17 KB, patch)
2020-02-19 12:10 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (7.24 KB, patch)
2020-03-30 09:27 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-02-18 13:17:32 PST
Since r246188, the WebProcess is launched eagerly when [WKWebView _restoreSessionState] is called. This is bad for performance because we are unable to leverage the process cache at this point (since we don't know which domain will be loaded).
Comment 1 Chris Dumez 2020-02-18 13:24:27 PST
Created attachment 391082 [details]
Patch
Comment 2 Geoffrey Garen 2020-02-18 22:02:13 PST
Comment on attachment 391082 [details]
Patch

Seems like the api test failure is real.
Comment 3 Chris Dumez 2020-02-19 12:08:17 PST
Comment on attachment 391082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391082&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:-3404
> -        m_backForwardList->restoreFromState(WTFMove(sessionState.backForwardListState));

lol, I dropped this line by mistake :o)
Comment 4 Chris Dumez 2020-02-19 12:10:44 PST
Created attachment 391189 [details]
Patch
Comment 5 WebKit Commit Bot 2020-02-19 22:25:48 PST
Comment on attachment 391189 [details]
Patch

Clearing flags on attachment: 391189

Committed r257045: <https://trac.webkit.org/changeset/257045>
Comment 6 WebKit Commit Bot 2020-02-19 22:25:50 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-02-19 22:26:13 PST
<rdar://problem/59619323>
Comment 8 WebKit Commit Bot 2020-02-20 12:01:29 PST
Re-opened since this is blocked by bug 208024
Comment 9 Chris Dumez 2020-03-30 09:27:55 PDT
Created attachment 394926 [details]
Patch
Comment 10 EWS 2020-03-30 10:35:14 PDT
Committed r259209: <https://trac.webkit.org/changeset/259209>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394926 [details].