Bug 207906 - Build failure on ppc64le if __unix is undefined
Summary: Build failure on ppc64le if __unix is undefined
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-18 13:05 PST by Mike Gorse
Modified: 2020-03-09 08:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch. (882 bytes, patch)
2020-02-18 13:18 PST, Mike Gorse 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gorse 2020-02-18 13:05:46 PST 
I'm getting a build failure building webkitgtk for ppc64le on SLE 15 (gcc 7.5.0).
__unix is undefined when building with -std=c++1z (but only on ppc64le, apparently), so BOS_UNIX doesn't get defined, leading to some headers not being included later. __unix__ is defined.
Comment 1 Mike Gorse 2020-02-18 13:18:47 PST 
Created attachment 391081 [details]
Patch.
Comment 2 Yusuke Suzuki 2020-03-09 00:18:49 PDT 
Comment on attachment 391081 [details]
Patch.

r=me
Comment 3 WebKit Commit Bot 2020-03-09 08:25:23 PDT 
Comment on attachment 391081 [details]
Patch.

Clearing flags on attachment: 391081

Committed r258142: <https://trac.webkit.org/changeset/258142>
Comment 4 WebKit Commit Bot 2020-03-09 08:25:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-03-09 08:26:19 PDT 
<rdar://problem/60223932>