Bug 207903 – NetworkDataTask should not expect its session wrapper to be always live

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[youenn fablet]

NetworkDataTask should not expect its session wrapper to be always live

[youenn fablet]

<rdar://problem/59291486>

[Radar WebKit Bug Importer]

<rdar://problem/59561689>

[youenn fablet]

<rdar://problem/59291486>

[youenn fablet]

Created attachment 391079 [details]
Patch

[youenn fablet]

Comment on attachment 391079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391079&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h:93
> +    WeakPtr<SessionWrapper> m_sessionWrapper;

I think the WeakPtr is necessary in case of SessionWrapper being an isolated session, which can be removed or cleared at various points in time.

[Alex Christensen]

Comment on attachment 391079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391079&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:321
>      if (!m_task || !m_session)

Let's just replace m_session with m_sessionWrapper, which is the only one used in this function.

[youenn fablet]

Created attachment 391088 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 391088 [details]
Patch for landing

Clearing flags on attachment: 391088

Committed r256857: <https://trac.webkit.org/changeset/256857>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.