Bug 207899 - [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
Summary: [macOS] Web process may crash under ServicesOverlayController::buildPotential...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-18 10:51 PST by Wenson Hsieh
Modified: 2020-02-18 15:15 PST (History)
8 users (show)

See Also:

Attachments
Patch (8.59 KB, patch)
2020-02-18 11:01 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
v2 (10.93 KB, patch)
2020-02-18 11:37 PST, Wenson Hsieh 		thorton: review+
wenson_hsieh: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-02-18 10:51:52 PST 
<rdar://problem/55658207>
Comment 1 Wenson Hsieh 2020-02-18 11:01:45 PST Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2020-02-18 11:34:30 PST 
Ah....it looks like my new test crashes on iOS :(

Going to augment my patch to fix this as well.
Comment 3 Wenson Hsieh 2020-02-18 11:37:10 PST 
Created attachment 391072 [details]
v2
Comment 4 Simon Fraser (smfr) 2020-02-18 14:44:57 PST 
Comment on attachment 391072 [details]
v2

View in context: https://bugs.webkit.org/attachment.cgi?id=391072&action=review

> Source/WebCore/page/mac/ServicesOverlayController.mm:547
>          FrameView* viewForRange = selectionRange->ownerDocument().view();

We usually do RefPtr<FrameView> these days.
Comment 5 Wenson Hsieh 2020-02-18 14:53:40 PST 
Comment on attachment 391072 [details]
v2

View in context: https://bugs.webkit.org/attachment.cgi?id=391072&action=review

>> Source/WebCore/page/mac/ServicesOverlayController.mm:547
>>          FrameView* viewForRange = selectionRange->ownerDocument().view();
> 
> We usually do RefPtr<FrameView> these days.

Sure, I’ll ref this (I originally wanted to avoid making any changes that weren’t necessary to fix the crash, but I guess my WebPageIOS change makes this point moot anyways :/)
Comment 6 Wenson Hsieh 2020-02-18 15:15:48 PST 
Committed r256859: <https://trac.webkit.org/changeset/256859>