Bug 207898 – Add an os_log PrintStream

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Keith Miller]

Add an os_log PrintStream

[Keith Miller]

Created attachment 391066 [details]
Patch

[Keith Miller]

Created attachment 391068 [details]
Patch

[Mark Lam]

Comment on attachment 391068 [details]
Patch

Patch missing files.

[Keith Miller]

Created attachment 391069 [details]
Patch

[Keith Miller]

Created attachment 391077 [details]
Patch

[Mark Lam]

Comment on attachment 391077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391077&action=review

r=me with JSC options added.

> Source/JavaScriptCore/jsc.cpp:2941
> +#if OS(DARWIN)
> +            setDataFile(OSLogPrintStream::open("com.apple.JavaScriptCore", "DataLog", OS_LOG_TYPE_INFO));
> +#else

Please add a JSC option to invoke this so that we can also enable this os logging for the WebProcess, or whatever process is using JSC.

[Keith Miller]

Created attachment 391127 [details]
Patch for landing

[Mark Lam]

Comment on attachment 391127 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=391127&action=review

> Source/JavaScriptCore/runtime/Options.cpp:621
> +                RELEASE_ASSERT(useOSLog());

Shouldn't this be Options::useOSLog()?

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 391127 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 391127 [details]:

imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html bug 206554 (authors: [e-mail] and [e-mail])
editing/spelling/spellcheck-attribute.html bug 206178 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 391127 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 391127 [details]
Patch for landing

Clearing flags on attachment: 391127

Committed r256910: <https://trac.webkit.org/changeset/256910>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59579166>