Bug 207898 - Add an os_log PrintStream
Summary: Add an os_log PrintStream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-18 10:51 PST by Keith Miller
Modified: 2020-02-18 21:38 PST (History)
15 users (show)

See Also:


Attachments
Patch (11.93 KB, patch)
2020-02-18 11:00 PST, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (11.93 KB, patch)
2020-02-18 11:02 PST, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (18.27 KB, patch)
2020-02-18 11:07 PST, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (18.92 KB, patch)
2020-02-18 12:43 PST, Keith Miller
no flags Details | Formatted Diff | Diff
Patch for landing (19.24 KB, patch)
2020-02-18 18:58 PST, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-02-18 10:51:16 PST
Add an os_log PrintStream
Comment 1 Keith Miller 2020-02-18 11:00:31 PST
Created attachment 391066 [details]
Patch
Comment 2 Keith Miller 2020-02-18 11:02:32 PST
Created attachment 391068 [details]
Patch
Comment 3 Mark Lam 2020-02-18 11:06:14 PST
Comment on attachment 391068 [details]
Patch

Patch missing files.
Comment 4 Keith Miller 2020-02-18 11:07:13 PST
Created attachment 391069 [details]
Patch
Comment 5 Keith Miller 2020-02-18 12:43:44 PST
Created attachment 391077 [details]
Patch
Comment 6 Mark Lam 2020-02-18 13:15:16 PST
Comment on attachment 391077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391077&action=review

r=me with JSC options added.

> Source/JavaScriptCore/jsc.cpp:2941
> +#if OS(DARWIN)
> +            setDataFile(OSLogPrintStream::open("com.apple.JavaScriptCore", "DataLog", OS_LOG_TYPE_INFO));
> +#else

Please add a JSC option to invoke this so that we can also enable this os logging for the WebProcess, or whatever process is using JSC.
Comment 7 Keith Miller 2020-02-18 18:58:47 PST
Created attachment 391127 [details]
Patch for landing
Comment 8 Mark Lam 2020-02-18 19:32:53 PST
Comment on attachment 391127 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=391127&action=review

> Source/JavaScriptCore/runtime/Options.cpp:621
> +                RELEASE_ASSERT(useOSLog());

Shouldn't this be Options::useOSLog()?
Comment 9 WebKit Commit Bot 2020-02-18 20:24:12 PST
The commit-queue encountered the following flaky tests while processing attachment 391127 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2020-02-18 20:24:42 PST
The commit-queue encountered the following flaky tests while processing attachment 391127 [details]:

imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html bug 206554 (authors: shvaikalesh@gmail.com and youennf@gmail.com)
editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2020-02-18 21:37:15 PST
The commit-queue encountered the following flaky tests while processing attachment 391127 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 12 WebKit Commit Bot 2020-02-18 21:37:49 PST
Comment on attachment 391127 [details]
Patch for landing

Clearing flags on attachment: 391127

Committed r256910: <https://trac.webkit.org/changeset/256910>
Comment 13 WebKit Commit Bot 2020-02-18 21:37:51 PST
All reviewed patches have been landed.  Closing bug.
Comment 14 Radar WebKit Bug Importer 2020-02-18 21:38:19 PST
<rdar://problem/59579166>