Bug 207885 - [ARM] Build failure on arm due to invalid use of incomplete type 'class WebCore::ImageData' in FEBlendNEON.h
Summary: [ARM] Build failure on arm due to invalid use of incomplete type 'class WebCo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Lord
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-18 03:56 PST by Chris Lord
Modified: 2020-02-18 08:40 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.27 KB, patch)
2020-02-18 03:59 PST, Chris Lord 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Lord 2020-02-18 03:56:34 PST 
> | In file included from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.cpp:28,
> |                  from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-28.cpp:1:
> | /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h: In member function 'virtual void WebCore::FEBlend::platformApplySoftware()':
> | /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h:115:52: error: invalid use of incomplete type 'class WebCore::ImageData'
> |   115 |     auto* dstPixelArray = imageResult ? imageResult->data() : nullptr;
> |       |                                                    ^~
> | In file included from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.h:25,
> |                  from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.cpp:26,
> |                  from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-28.cpp:1:

I don't know what the best fix is, but including ImageData.h in FEBlendNEON.h does fix it, so I'll attach that patch.
Comment 1 Chris Lord 2020-02-18 03:59:31 PST 
Created attachment 391039 [details]
Patch
Comment 2 WebKit Commit Bot 2020-02-18 06:15:45 PST 
Comment on attachment 391039 [details]
Patch

Clearing flags on attachment: 391039

Committed r256825: <https://trac.webkit.org/changeset/256825>
Comment 3 WebKit Commit Bot 2020-02-18 06:15:47 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-02-18 06:16:13 PST 
<rdar://problem/59547710>
Comment 5 Said Abou-Hallawa 2020-02-18 08:40:52 PST 
(In reply to Chris Lord from comment #0)
> > | In file included from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.cpp:28,
> > |                  from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-28.cpp:1:
> > | /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h: In member function 'virtual void WebCore::FEBlend::platformApplySoftware()':
> > | /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h:115:52: error: invalid use of incomplete type 'class WebCore::ImageData'
> > |   115 |     auto* dstPixelArray = imageResult ? imageResult->data() : nullptr;
> > |       |                                                    ^~
> > | In file included from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.h:25,
> > |                  from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.cpp:26,
> > |                  from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-28.cpp:1:
> 
> I don't know what the best fix is, but including ImageData.h in
> FEBlendNEON.h does fix it, so I'll attach that patch.

Yes this is the right fix. It is caused by the unified sources compilation. Thanks for taking care of this failure.