Bug 20788 - Split CharacterClassConstructor into its own file
: Split CharacterClassConstructor into its own file
Status: RESOLVED FIXED
: WebKit
JavaScriptCore
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2008-09-11 13:29 PST by
Modified: 2008-09-11 15:47 PST (History)


Attachments
Proposed patch (36.80 KB, patch)
2008-09-11 13:32 PST, Cameron Zwarich (cpst)
no flags Review Patch | Details | Formatted Diff | Diff
Revised proposed patch (36.67 KB, patch)
2008-09-11 13:39 PST, Cameron Zwarich (cpst)
mjs: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2008-09-11 13:29:09 PST
We should really split WREC into multiple pieces. I have a patch that does this for CharacterClassConstructor.
------- Comment #1 From 2008-09-11 13:32:38 PST -------
Created an attachment (id=23357) [details]
Proposed patch

Sorry that the renames don't come out in the diff, but they can all be seen in CharacterClassConstructor.h
------- Comment #2 From 2008-09-11 13:39:18 PST -------
Created an attachment (id=23358) [details]
Revised proposed patch

I forgot to make CharacterClassConstructor a class rather than a struct, and I had an unused accessor function.
------- Comment #3 From 2008-09-11 14:07:07 PST -------
(From update of attachment 23358 [details])
r=me
------- Comment #4 From 2008-09-11 14:07:07 PST -------
(From update of attachment 23358 [details])
r=me
------- Comment #5 From 2008-09-11 15:47:47 PST -------
Landed in r36337 and r36338.