WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
20788
Split CharacterClassConstructor into its own file
https://bugs.webkit.org/show_bug.cgi?id=20788
Summary
Split CharacterClassConstructor into its own file
Cameron Zwarich (cpst)
Reported
2008-09-11 13:29:09 PDT
We should really split WREC into multiple pieces. I have a patch that does this for CharacterClassConstructor.
Attachments
Proposed patch
(36.80 KB, patch)
2008-09-11 13:32 PDT
,
Cameron Zwarich (cpst)
no flags
Details
Formatted Diff
Diff
Revised proposed patch
(36.67 KB, patch)
2008-09-11 13:39 PDT
,
Cameron Zwarich (cpst)
mjs
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Cameron Zwarich (cpst)
Comment 1
2008-09-11 13:32:38 PDT
Created
attachment 23357
[details]
Proposed patch Sorry that the renames don't come out in the diff, but they can all be seen in CharacterClassConstructor.h
Cameron Zwarich (cpst)
Comment 2
2008-09-11 13:39:18 PDT
Created
attachment 23358
[details]
Revised proposed patch I forgot to make CharacterClassConstructor a class rather than a struct, and I had an unused accessor function.
Maciej Stachowiak
Comment 3
2008-09-11 14:07:07 PDT
Comment on
attachment 23358
[details]
Revised proposed patch r=me
Maciej Stachowiak
Comment 4
2008-09-11 14:07:07 PDT
Comment on
attachment 23358
[details]
Revised proposed patch r=me
Cameron Zwarich (cpst)
Comment 5
2008-09-11 15:47:47 PDT
Landed in
r36337
and
r36338
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug