Bug 20788 - Split CharacterClassConstructor into its own file
Summary: Split CharacterClassConstructor into its own file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Cameron Zwarich (cpst)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-11 13:29 PDT by Cameron Zwarich (cpst)
Modified: 2008-09-11 15:47 PDT (History)
0 users

See Also:

Attachments
Proposed patch (36.80 KB, patch)
2008-09-11 13:32 PDT, Cameron Zwarich (cpst) 		no flags Details | Formatted Diff | Diff
Revised proposed patch (36.67 KB, patch)
2008-09-11 13:39 PDT, Cameron Zwarich (cpst) 		mjs: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2008-09-11 13:29:09 PDT 
We should really split WREC into multiple pieces. I have a patch that does this for CharacterClassConstructor.
Comment 1 Cameron Zwarich (cpst) 2008-09-11 13:32:38 PDT 
Created attachment 23357 [details]
Proposed patch

Sorry that the renames don't come out in the diff, but they can all be seen in CharacterClassConstructor.h
Comment 2 Cameron Zwarich (cpst) 2008-09-11 13:39:18 PDT 
Created attachment 23358 [details]
Revised proposed patch

I forgot to make CharacterClassConstructor a class rather than a struct, and I had an unused accessor function.
Comment 3 Maciej Stachowiak 2008-09-11 14:07:07 PDT 
Comment on attachment 23358 [details]
Revised proposed patch

r=me
Comment 4 Maciej Stachowiak 2008-09-11 14:07:07 PDT 
Comment on attachment 23358 [details]
Revised proposed patch

r=me
Comment 5 Cameron Zwarich (cpst) 2008-09-11 15:47:47 PDT 
Landed in r36337 and r36338.