RESOLVED FIXED 207879
[LFC][TreeBuilding] Take createLineBreakBox's return value 
https://bugs.webkit.org/show_bug.cgi?id=207879
Summary [LFC][TreeBuilding] Take createLineBreakBox's return value
zalan
Reported 2020-02-17 20:59:54 PST
childLayoutBox = &createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle))
Attachments
Patch (3.89 KB, patch)
2020-02-17 21:07 PST, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-17 21:00:18 PST
<rdar://problem/59537585>
zalan
Comment 2 2020-02-17 21:07:04 PST
Created attachment 391027 [details] Patch
Antti Koivisto
Comment 3 2020-02-18 02:45:09 PST
Comment on attachment 391027 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391027&action=review > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:216 > - createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle)); > + childLayoutBox = &createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle)); lol
WebKit Commit Bot
Comment 4 2020-02-18 06:57:58 PST
Comment on attachment 391027 [details] Patch Clearing flags on attachment: 391027 Committed r256827: <https://trac.webkit.org/changeset/256827>
WebKit Commit Bot
Comment 5 2020-02-18 06:58:00 PST
All reviewed patches have been landed. Closing bug.
zalan
Comment 6 2020-02-18 07:18:35 PST
(In reply to Antti Koivisto from comment #3) > Comment on attachment 391027 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391027&action=review > > > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:216 > > - createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle)); > > + childLayoutBox = &createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle)); > > lol exactly my thoughts.
Note You need to log in before you can comment on or make changes to this bug.