Bug 207870 – Move from "layer flush" terminology to "rendering update"

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Move from "layer flush" terminology to "rendering update"

[Simon Fraser (smfr)]

Created attachment 391002 [details]
Patch

[Tim Horton]

Comment on attachment 391002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391002&action=review

> Source/WebCore/page/ChromeClient.h:342
> +    virtual bool adjustRenderUpdateThrottling(OptionSet<RenderingUpdateThrottleState>) { return false; }

should this be an -ing?

> Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:159
> +    bool m_nextRenderingUpdateIsImmediate { false };

If we're changing the name, can we change it to something less mysterious?

[Simon Fraser (smfr)]

Created attachment 391010 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 391020 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 391032 [details]
Patch

[Antti Koivisto]

Comment on attachment 391032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391032&action=review

> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:211
> +        }
>  }

Weird indentation.

[Antti Koivisto]

Is there some terminology confusion here with the HTML concept of "rendering update"? To reach visually non-empty state we need to update layout without doing any layer flushes. Should there be a concept of "visual rendering update" or similar?

[Simon Fraser (smfr)]

(In reply to Antti Koivisto from comment #7)
> Is there some terminology confusion here with the HTML concept of "rendering
> update"?

Perhaps, but I was trying to match this terminology on purpose.

> To reach visually non-empty state we need to update layout without
> doing any layer flushes. Should there be a concept of "visual rendering
> update" or similar?

Probably!

[WebKit Commit Bot]

Comment on attachment 391032 [details]
Patch

Clearing flags on attachment: 391032

Committed r256834: <https://trac.webkit.org/changeset/256834>

[Radar WebKit Bug Importer]

<rdar://problem/59822371>