RESOLVED FIXED 207865
Rename dispatchDidReceiveEditorStateAfterFocus() to dispatchDidUpdateEditorState() to better describe its purpose 
https://bugs.webkit.org/show_bug.cgi?id=207865
Summary Rename dispatchDidReceiveEditorStateAfterFocus() to dispatchDidUpdateEditorSt...
Daniel Bates
Reported 2020-02-17 15:19:26 PST
WebPageProxy::dispatchDidReceiveEditorStateAfterFocus() is called either when the WebKit receives a layer commit message or an editor state changed messaged, which may or may not be after an element is focused. Note that for all non-iOS ports WebPageProxy::dispatchDidReceiveEditorStateAfterFocus() does nothing. For iOS the implementation currently conditionalizes itself on m_waitingForPostLayoutEditorStateUpdateAfterFocusingElement because iOS defers zooming and scrolling when an element is focused until it receives an editor state update. But that is just an implementation detail of iOS. Fact remains that WebPageProxy::dispatchDidReceiveEditorStateAfterFocus() is called more often that after an element is focused. Ideally, the iOS implementation of WebPageProxy::dispatchDidReceiveEditorStateAfterFocus() should move from WebPageProxyIOS.mm to WebPageProxy.cpp. For now, let's rename it so that it better describes its purpose.
Attachments
Patch (9.15 KB, patch)
2020-02-17 15:24 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2020-02-17 15:24:35 PST
Created attachment 390993 [details] Patch
Daniel Bates
Comment 2 2020-02-17 15:26:35 PST
Thank you!
Daniel Bates
Comment 3 2020-02-18 09:11:25 PST
Comment on attachment 390993 [details] Patch Clearing flags on attachment: 390993 Committed r256833: <https://trac.webkit.org/changeset/256833>
Daniel Bates
Comment 4 2020-02-18 09:11:28 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-02-18 09:12:17 PST
<rdar://problem/59552009>
Note You need to log in before you can comment on or make changes to this bug.