Bug 207860 - REGRESSION (r251320): Data detectors do not trigger on macCatalyst
Summary: REGRESSION (r251320): Data detectors do not trigger on macCatalyst
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-17 14:16 PST by Megan Gardner
Modified: 2020-02-17 16:50 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.73 KB, patch)
2020-02-17 14:19 PST, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch for landing (1.71 KB, patch)
2020-02-17 14:41 PST, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2020-02-17 14:16:06 PST
Send touches to data detectors gesture on macCataylst as the gesture currently runs on touch data.
Comment 1 Megan Gardner 2020-02-17 14:19:13 PST
Created attachment 390979 [details]
Patch
Comment 2 Megan Gardner 2020-02-17 14:20:02 PST
<rdar://problem/59038913>
Comment 3 Tim Horton 2020-02-17 14:26:31 PST
Comment on attachment 390979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390979&action=review

> Source/WebKit/ChangeLog:3
> +        Send touches to data detectors gesture on macCataylst as the gesture currently runs on touch data.

DataDetectors, macCatalyst (the y is misplaced), also this should be the "problem" not the "solution" ("REGRESSION (r???): Data Detectors gesture does not trigger in macCatalyst")
Comment 4 Megan Gardner 2020-02-17 14:41:06 PST
Created attachment 390983 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2020-02-17 16:50:46 PST
Comment on attachment 390983 [details]
Patch for landing

Clearing flags on attachment: 390983

Committed r256790: <https://trac.webkit.org/changeset/256790>
Comment 6 WebKit Commit Bot 2020-02-17 16:50:47 PST
All reviewed patches have been landed.  Closing bug.