Bug 207838 - [GTK][WPE] Set ccache as compiler launcher, add opt-in sccache support
Summary: [GTK][WPE] Set ccache as compiler launcher, add opt-in sccache support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-17 06:16 PST by Philippe Normand
Modified: 2020-02-20 08:48 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.83 KB, patch)
2020-02-17 06:20 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (2.13 KB, patch)
2020-02-17 08:49 PST, Philippe Normand 		clopez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2020-02-17 06:16:24 PST 
.
Comment 1 Philippe Normand 2020-02-17 06:20:02 PST 
Created attachment 390916 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2020-02-17 08:05:51 PST 
Comment on attachment 390916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390916&action=review

> Source/cmake/WebKitCCache.cmake:6
>          set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ${CMAKE_SOURCE_DIR}/Tools/ccache/ccache-wrapper)

I don't like much the idea of calling a bash wrapper instead of ccache directly just to export two environment variables.
I think exporting this environment variables can be done also by CMake and we can call ccache directly avoiding the overhead of calling as extra env+bash for each compilation unit.
Comment 3 Philippe Normand 2020-02-17 08:33:14 PST 
Comment on attachment 390916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390916&action=review

>> Source/cmake/WebKitCCache.cmake:6
>>          set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ${CMAKE_SOURCE_DIR}/Tools/ccache/ccache-wrapper)
> 
> I don't like much the idea of calling a bash wrapper instead of ccache directly just to export two environment variables.
> I think exporting this environment variables can be done also by CMake and we can call ccache directly avoiding the overhead of calling as extra env+bash for each compilation unit.

OK then I won't touch this Mac-specific code. Actually I don't think we need those vars for GTK/WPE. Besides, the ccache-wrapper is called by the "clang-wrapper"...
Comment 4 Philippe Normand 2020-02-17 08:49:53 PST 
Created attachment 390924 [details]
Patch
Comment 5 Philippe Normand 2020-02-19 04:50:23 PST 
Committed r256917: <https://trac.webkit.org/changeset/256917>