Bug 207834 - Fix check-webkit-style errors related to AVFoundationSPI.h
Summary: Fix check-webkit-style errors related to AVFoundationSPI.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-16 22:43 PST by Peng Liu
Modified: 2020-02-19 16:57 PST (History)
15 users (show)

See Also:

Attachments
WIP patch (20.15 KB, patch)
2020-02-17 00:06 PST, Peng Liu 		no flags Details | Formatted Diff | Diff
Soft-link headers can be included either in "file.h" or <file.h> (18.34 KB, patch)
2020-02-17 10:25 PST, Peng Liu 		no flags Details | Formatted Diff | Diff
Patch (1.89 KB, patch)
2020-02-18 21:00 PST, Peng Liu 		no flags Details | Formatted Diff | Diff
Updated follow-up patch to revert the change regarding header order (4.46 KB, patch)
2020-02-19 12:28 PST, Peng Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2020-02-16 22:43:51 PST 
Fix check-webkit-style errors related to AVFoundationSPI.h
Comment 1 Peng Liu 2020-02-17 00:06:30 PST 
Created attachment 390904 [details]
WIP patch
Comment 2 Peng Liu 2020-02-17 10:25:35 PST 
Created attachment 390932 [details]
Soft-link headers can be included either in "file.h" or <file.h>
Comment 3 Radar WebKit Bug Importer 2020-02-17 13:19:19 PST 
<rdar://problem/59523191>
Comment 4 WebKit Commit Bot 2020-02-17 13:55:56 PST 
Comment on attachment 390932 [details]
Soft-link headers can be included either in "file.h" or <file.h>

Clearing flags on attachment: 390932

Committed r256770: <https://trac.webkit.org/changeset/256770>
Comment 5 WebKit Commit Bot 2020-02-17 13:55:58 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2020-02-18 20:13:03 PST 
Comment on attachment 390932 [details]
Soft-link headers can be included either in "file.h" or <file.h>

View in context: https://bugs.webkit.org/attachment.cgi?id=390932&action=review

> Tools/ChangeLog:8
> +        We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.

What? No! Who decided this? I do not agree that this should change.

We aren’t switching to case-insensitive comparison. There are thousands or source files and they are sorted case sensitively. This needs to be rolled back.
Comment 7 Peng Liu 2020-02-18 20:49:03 PST 
Comment on attachment 390932 [details]
Soft-link headers can be included either in "file.h" or <file.h>

View in context: https://bugs.webkit.org/attachment.cgi?id=390932&action=review

>> Tools/ChangeLog:8
>> +        We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
> 
> What? No! Who decided this? I do not agree that this should change.
> 
> We aren’t switching to case-insensitive comparison. There are thousands or source files and they are sorted case sensitively. This needs to be rolled back.

Oh, sorry, you are right. I just reviewed the code style guidelines. That was done by mistake. Will reopen this bug and rollout this change.
Comment 8 Peng Liu 2020-02-18 20:50:44 PST 
Reopen this bug to rollout the change regarding the headers ordering.
Comment 9 Peng Liu 2020-02-18 21:00:54 PST 
Created attachment 391140 [details]
Patch
Comment 10 Peng Liu 2020-02-19 12:28:04 PST 
Created attachment 391190 [details]
Updated follow-up patch to revert the change regarding header order
Comment 11 Daniel Bates 2020-02-19 14:33:29 PST 
Comment on attachment 391190 [details]
Updated follow-up patch to revert the change regarding header order

r=me
Comment 12 WebKit Commit Bot 2020-02-19 16:57:31 PST 
Comment on attachment 391190 [details]
Updated follow-up patch to revert the change regarding header order

Clearing flags on attachment: 391190

Committed r257003: <https://trac.webkit.org/changeset/257003>
Comment 13 WebKit Commit Bot 2020-02-19 16:57:33 PST 
All reviewed patches have been landed.  Closing bug.