RESOLVED FIXED 207832
[LFC][Out-of-flow] FormattingContext::computeOutOfFlowHorizontalGeometry needs verticalConstraints 
https://bugs.webkit.org/show_bug.cgi?id=207832
Summary [LFC][Out-of-flow] FormattingContext::computeOutOfFlowHorizontalGeometry need...
zalan
Reported 2020-02-16 20:36:02 PST
while figuring out computedContentHeight through inlineReplacedWidthAndMargin
Attachments
Patch (19.40 KB, patch)
2020-02-16 21:08 PST, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-16 20:36:25 PST
<rdar://problem/59499844>
zalan
Comment 2 2020-02-16 21:08:06 PST
Created attachment 390898 [details] Patch
Dean Jackson
Comment 3 2020-02-17 09:30:09 PST
Comment on attachment 390898 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390898&action=review > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:286 > + contentWidthAndMargin = geometry().inlineReplacedWidthAndMargin(downcast<ReplacedBox>(layoutBox), horizontalConstraints, { }, usedWidth); Shouldn't the {}s be nullopts?
WebKit Commit Bot
Comment 4 2020-02-17 12:29:15 PST
Comment on attachment 390898 [details] Patch Clearing flags on attachment: 390898 Committed r256760: <https://trac.webkit.org/changeset/256760>
WebKit Commit Bot
Comment 5 2020-02-17 12:29:16 PST
All reviewed patches have been landed. Closing bug.
zalan
Comment 6 2020-02-17 13:11:11 PST
(In reply to Dean Jackson from comment #3) > Comment on attachment 390898 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390898&action=review > > > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:286 > > + contentWidthAndMargin = geometry().inlineReplacedWidthAndMargin(downcast<ReplacedBox>(layoutBox), horizontalConstraints, { }, usedWidth); > > Shouldn't the {}s be nullopts? {} is nullopt when the type is WTF::Optional.
Note You need to log in before you can comment on or make changes to this bug.