while figuring out computedContentHeight through inlineReplacedWidthAndMargin
<rdar://problem/59499844>
Created attachment 390898 [details] Patch
Comment on attachment 390898 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390898&action=review > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:286 > + contentWidthAndMargin = geometry().inlineReplacedWidthAndMargin(downcast<ReplacedBox>(layoutBox), horizontalConstraints, { }, usedWidth); Shouldn't the {}s be nullopts?
Comment on attachment 390898 [details] Patch Clearing flags on attachment: 390898 Committed r256760: <https://trac.webkit.org/changeset/256760>
All reviewed patches have been landed. Closing bug.
(In reply to Dean Jackson from comment #3) > Comment on attachment 390898 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390898&action=review > > > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:286 > > + contentWidthAndMargin = geometry().inlineReplacedWidthAndMargin(downcast<ReplacedBox>(layoutBox), horizontalConstraints, { }, usedWidth); > > Shouldn't the {}s be nullopts? {} is nullopt when the type is WTF::Optional.