Bug 207819 – Web Inspector: Add "outline focused element" debug setting

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

When debugging accessibility issues of Web Inspector, it's helpful to know what element is focused. Many elements have "outline: none" and no clear indication what's focused.

Add a debug setting to show a bright outline for all focused elements.

[Radar WebKit Bug Importer]

<rdar://problem/59489993>

[Nikita Vasilyev]

Created attachment 390877 [details]
Patch

[Nikita Vasilyev]

Created attachment 390879 [details]
[Image] With patch applied

[WebKit Commit Bot]

Comment on attachment 390877 [details]
Patch

Clearing flags on attachment: 390877

Committed r256788: <https://trac.webkit.org/changeset/256788>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Devin Rousso]

Comment on attachment 390877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390877&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:568
> +    function setFocusDebugOutline() {

This should really exist inside 'Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js' so we don't ship it when it's not going to be usable.

> Source/WebInspectorUI/UserInterface/Views/Main.css:124
> +body.focus-debug *:focus {

This should really exist inside 'Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css' (which we should create) so we don't ship it when it's not going to be usable.