Bug 207814 - [LFC][BFC] ConstraintsPair is only needed for the pre-computed vertical position
Summary: [LFC][BFC] ConstraintsPair is only needed for the pre-computed vertical position
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-15 05:35 PST by zalan
Modified: 2020-02-17 13:39 PST (History)
5 users (show)

See Also:

Attachments
Patch (14.96 KB, patch)
2020-02-15 05:39 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (14.33 KB, patch)
2020-02-15 07:22 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (17.41 KB, patch)
2020-02-15 13:54 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-02-15 05:35:42 PST 
After r256099, ConstraintsPair is only need in few functions.
Comment 1 Radar WebKit Bug Importer 2020-02-15 05:36:03 PST 
<rdar://problem/59485612>
Comment 2 zalan 2020-02-15 05:39:52 PST 
Created attachment 390865 [details]
Patch
Comment 3 Antti Koivisto 2020-02-15 06:18:33 PST 
Comment on attachment 390865 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390865&action=review

> Source/WebCore/ChangeLog:9
> +        After r256099 (Pre-compute vertical position only when we really need it), ConstraintsPair<> is only

Can it be removed entirely?
Comment 4 zalan 2020-02-15 07:22:36 PST 
Created attachment 390867 [details]
Patch
Comment 5 zalan 2020-02-15 13:54:58 PST 
Created attachment 390871 [details]
Patch
Comment 6 zalan 2020-02-15 14:01:25 PST 
Committed r256704: <https://trac.webkit.org/changeset/256704>
Comment 7 zalan 2020-02-17 13:39:39 PST 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 390865 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=390865&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        After r256099 (Pre-compute vertical position only when we really need it), ConstraintsPair<> is only
> 
> Can it be removed entirely?
Unfortunately not, some quirk functions (when we pre-compute the vertical position on the ancestors) still need both the root and the containing block values.