RESOLVED FIXED 207814
[LFC][BFC] ConstraintsPair is only needed for the pre-computed vertical position 
https://bugs.webkit.org/show_bug.cgi?id=207814
Summary [LFC][BFC] ConstraintsPair is only needed for the pre-computed vertical position
alan baradlay
Reported 2020-02-15 05:35:42 PST
After r256099, ConstraintsPair is only need in few functions.
Attachments
Patch (14.96 KB, patch)
2020-02-15 05:39 PST, alan baradlay 		no flags
DetailsFormatted DiffDiff
Patch (14.33 KB, patch)
2020-02-15 07:22 PST, alan baradlay 		no flags
DetailsFormatted DiffDiff
Patch (17.41 KB, patch)
2020-02-15 13:54 PST, alan baradlay 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-15 05:36:03 PST
<rdar://problem/59485612>
alan baradlay
Comment 2 2020-02-15 05:39:52 PST
Created attachment 390865 [details] Patch
Antti Koivisto
Comment 3 2020-02-15 06:18:33 PST
Comment on attachment 390865 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390865&action=review > Source/WebCore/ChangeLog:9 > + After r256099 (Pre-compute vertical position only when we really need it), ConstraintsPair<> is only Can it be removed entirely?
alan baradlay
Comment 4 2020-02-15 07:22:36 PST
Created attachment 390867 [details] Patch
alan baradlay
Comment 5 2020-02-15 13:54:58 PST
Created attachment 390871 [details] Patch
alan baradlay
Comment 6 2020-02-15 14:01:25 PST
Committed r256704: <https://trac.webkit.org/changeset/256704>
alan baradlay
Comment 7 2020-02-17 13:39:39 PST
(In reply to Antti Koivisto from comment #3) > Comment on attachment 390865 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390865&action=review > > > Source/WebCore/ChangeLog:9 > > + After r256099 (Pre-compute vertical position only when we really need it), ConstraintsPair<> is only > > Can it be removed entirely? Unfortunately not, some quirk functions (when we pre-compute the vertical position on the ancestors) still need both the root and the containing block values.
Note You need to log in before you can comment on or make changes to this bug.