Do not send the client URL to network process. This is unnecessary and somehow unsafe.
Created attachment 390847 [details] Patch
Created attachment 390850 [details] Patch
Comment on attachment 390850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390850&action=review > Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:296 > + auto iterator = m_clientOrigins.find(clientIdentifier); > + if (iterator != m_clientOrigins.end()) > + clientData = server().serviceWorkerClientWithOriginByID(iterator->value, clientIdentifier); > + if (!clientData) > + return { }; I think this would read better like this: auto iterator = m_clientOrigins.find(clientIdentifier); if (iterator == m_clientOrigins.end()) return { }; auto clientData = server().serviceWorkerClientWithOriginByID(iterator->value, clientIdentifier); if (!clientData) return { };
Created attachment 390929 [details] Patch for landing
Comment on attachment 390929 [details] Patch for landing Clearing flags on attachment: 390929 Committed r256749: <https://trac.webkit.org/changeset/256749>
All reviewed patches have been landed. Closing bug.
<rdar://problem/59518840>