Bug 207795 - Stop using QTKit for rendering WK1 video fullscreen controls
Summary: Stop using QTKit for rendering WK1 video fullscreen controls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-14 14:54 PST by Jer Noble
Modified: 2020-03-10 15:06 PDT (History)
13 users (show)

See Also:


Attachments
Patch (75.75 KB, patch)
2020-02-14 15:05 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (77.76 KB, patch)
2020-02-17 10:13 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (77.83 KB, patch)
2020-02-17 11:02 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (82.07 KB, patch)
2020-02-17 11:58 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (84.06 KB, patch)
2020-02-17 13:42 PST, Jer Noble
jonlee: review+
Details | Formatted Diff | Diff
Patch for landing (85.50 KB, patch)
2020-02-22 14:34 PST, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-02-14 14:54:58 PST
Stop using QTKit for rendering WK1 video fullscreen controls
Comment 1 Jer Noble 2020-02-14 14:55:45 PST
<rdar://problem/48894915>
Comment 2 Jer Noble 2020-02-14 15:05:03 PST
Created attachment 390828 [details]
Patch
Comment 3 Xabier Rodríguez Calvar 2020-02-17 02:05:18 PST
Comment on attachment 390828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390828&action=review

> Source/WebKitLegacy/mac/ChangeLog:12
> +        move the fullscreen winodw to a separate space. This requires subclassing AVPlayerView so that

window
Comment 4 Jer Noble 2020-02-17 10:13:31 PST
Created attachment 390931 [details]
Patch
Comment 5 Aakash Jain 2020-02-17 10:29:17 PST
Comment on attachment 390931 [details]
Patch

Seems to break the build:

iOS:
PAL/pal/spi/cocoa/AVKitSPI.h:33:33: error: cannot find interface declaration for 'UIResponder', superclass of 'AVPlayerController'
https://ews-build.webkit.org/#/builders/23/builds/10800/steps/7/logs/errors

macOS:
clang: error: no such file or directory: '/Volumes/Data/worker/macOS-Mojave-Release-Build-EWS/build/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.mm'
https://ews-build.webkit.org/#/builders/33/builds/3067/steps/7/logs/errors
Comment 6 Jer Noble 2020-02-17 11:02:37 PST
Created attachment 390942 [details]
Patch
Comment 7 Jer Noble 2020-02-17 11:58:29 PST
Created attachment 390957 [details]
Patch
Comment 8 Jer Noble 2020-02-17 13:42:21 PST
Created attachment 390970 [details]
Patch
Comment 9 Jon Lee 2020-02-19 16:40:34 PST
Comment on attachment 390970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390970&action=review

> Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm:193
> +//    [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(applicationDidChangeScreenParameters:) name:NSApplicationDidChangeScreenParametersNotification object:NSApp];

please remove.
Comment 10 Jer Noble 2020-02-22 14:34:50 PST
Created attachment 391468 [details]
Patch for landing
Comment 11 WebKit Commit Bot 2020-02-22 21:46:02 PST
Comment on attachment 391468 [details]
Patch for landing

Clearing flags on attachment: 391468

Committed r257189: <https://trac.webkit.org/changeset/257189>