Bug 207794 – Add WebInspector support to WebKit::WebSocketChannel

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Add WebInspector support to WebKit::WebSocketChannel

[youenn fablet]

Created attachment 390826 [details]
Patch

[youenn fablet]

Created attachment 390827 [details]
Patch

[youenn fablet]

Created attachment 390831 [details]
Patch

[youenn fablet]

Created attachment 390845 [details]
Patch

[Darin Adler]

Comment on attachment 390845 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390845&action=review

> Source/WebCore/Modules/websockets/WebSocketChannelInspector.h:50
> +    unsigned long m_progressIdentifier { 0 };

The use of “long” here seems questionable. An unsigned is already 32 bits, just like an unsigned long.

> Source/WebKit/WebProcess/Network/WebSocketChannel.cpp:53
> +    WebSocketFrame frame(opCode, true, false, true, data, length);

Sure seems mysterious, written like this.

[youenn fablet]

Created attachment 390936 [details]
Patch for landing

[youenn fablet]

(In reply to Darin Adler from comment #5)
> Comment on attachment 390845 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=390845&action=review
> 
> > Source/WebCore/Modules/websockets/WebSocketChannelInspector.h:50
> > +    unsigned long m_progressIdentifier { 0 };

Changed it to unsigned.

> The use of “long” here seems questionable. An unsigned is already 32 bits,
> just like an unsigned long.
> 
> > Source/WebKit/WebProcess/Network/WebSocketChannel.cpp:53
> > +    WebSocketFrame frame(opCode, true, false, true, data, length);
> 
> Sure seems mysterious, written like this.

Reused the other routine that is indeed clearer.

[WebKit Commit Bot]

Comment on attachment 390936 [details]
Patch for landing

Clearing flags on attachment: 390936

Committed r256762: <https://trac.webkit.org/changeset/256762>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59522008>