Bug 207787 – [Webkit.css] Adding popover style

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zhifei Fang]

[Webkit.css] Adding popover style

[Zhifei Fang]

Created attachment 390807 [details]
Patch

[Zhifei Fang]

<rdar://problem/59412833>

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 390807 [details]:

http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 390807 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 390807 [details]
Patch

Clearing flags on attachment: 390807

Committed r256807: <https://trac.webkit.org/changeset/256807>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59535887>

[Jonathan Bedard]

I like the idea of a shared pop-over style, I do think that we need to iterate a bit here. The results database uses a different pop-over style at the moment, there are some things I like about that style, some that I like about yours.

I like the arrow and shadow (both on the arrow and the pop-over) on this new style better than what the results-database does.

I don't like the sharp corners, and I prefer the rounded corners of the results-database.

I'm a bit torn on the color. I suppose it's configurable, but it never felt right to me to have the background color of the pop-over be the same as the background color of the site, especially as the pop-overs get bigger. On the other hand, the heavy blurring that the results database does can be distracting.