fast/events/keydown-1.htm Description: This test is flaky failing occasionally in Mac wk2. The oldest diff that I can load, r254940, is the same. There are other flaky failures before that that are likely the same. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fevents%2Fkeydown-1.html&platform=mac&limit=50000&style=release&flavor=wk2 Diff: --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/fast/events/keydown-1-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/fast/events/keydown-1-actual.txt @@ -3,4 +3,4 @@ keydown in subframe: [object KeyboardEvent] keydown in subframe: [object KeyboardEvent] -This sentence should not end with a period +
<rdar://problem/59469424>
I have marked this test as failing while this issue is investigated. https://trac.webkit.org/changeset/256639/webkit
Created attachment 390857 [details] proposed patch
We had an older bug for this (bug 154297), but this one has a radar associated with it, so posting the speculative fix here.
*** Bug 154297 has been marked as a duplicate of this bug. ***
Comment on attachment 390857 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=390857&action=review > LayoutTests/platform/mac-wk2/TestExpectations:-1043 > -<<<<<<< Updated upstream Looks like some unresolved conflict.
Comment on attachment 390857 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=390857&action=review >> LayoutTests/platform/mac-wk2/TestExpectations:-1043 >> -<<<<<<< Updated upstream > > Looks like some unresolved conflict. It seems this was landed by accident in r256656; this patch is fixing it.
(In reply to Wenson Hsieh from comment #7) > Comment on attachment 390857 [details] > proposed patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390857&action=review > > >> LayoutTests/platform/mac-wk2/TestExpectations:-1043 > >> -<<<<<<< Updated upstream > > > > Looks like some unresolved conflict. > > It seems this was landed by accident in r256656; this patch is fixing it. thanks greyscale mode. :(
Comment on attachment 390857 [details] proposed patch Rejecting attachment 390857 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 390857, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=390857&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=207785&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 390857 from bug 207785. Fetching: https://bugs.webkit.org/attachment.cgi?id=390857 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Wenson Hsieh']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 4 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/events/keydown-1.html patching file LayoutTests/platform/mac-wk1/TestExpectations patching file LayoutTests/platform/mac-wk2/TestExpectations Hunk #1 FAILED at 1038. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac-wk2/TestExpectations.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Wenson Hsieh']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13323639
Committed r256717. Dean already removed the markers, but he resolved the conflict in the wrong direction, so follow-up was still needed.