Bug 207780 - fix flaky tests that scroll before first paint
Summary: fix flaky tests that scroll before first paint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
: 207781 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-02-14 11:09 PST by Ben Nham
Modified: 2020-02-14 17:01 PST (History)
10 users (show)

See Also:


Attachments
Patch (2.91 KB, patch)
2020-02-14 11:14 PST, Ben Nham
no flags Details | Formatted Diff | Diff
Patch (2.91 KB, patch)
2020-02-14 11:46 PST, Ben Nham
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-03 for mac-mojave (3.15 MB, application/zip)
2020-02-14 13:59 PST, WebKit Commit Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2020-02-14 11:09:18 PST
After https://bugs.webkit.org/show_bug.cgi?id=207516, a couple of tests are now flaky. This is because that patch delays first paint until there is enough content to render, and some of these tests are issuing scroll events on controls before those controls render. To fix this, we delay issuing the events until after the page loads.
Comment 1 Ben Nham 2020-02-14 11:14:28 PST
Created attachment 390788 [details]
Patch
Comment 2 Ben Nham 2020-02-14 11:44:33 PST
*** Bug 207781 has been marked as a duplicate of this bug. ***
Comment 3 Ben Nham 2020-02-14 11:46:47 PST
Created attachment 390790 [details]
Patch
Comment 4 Alexey Proskuryakov 2020-02-14 12:47:41 PST
<rdar://problem/59466307>
Comment 5 WebKit Commit Bot 2020-02-14 13:44:54 PST
The commit-queue encountered the following flaky tests while processing attachment 390790 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-02-14 13:44:55 PST
The commit-queue encountered the following flaky tests while processing attachment 390790 [details]:

The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2020-02-14 13:59:31 PST
Comment on attachment 390790 [details]
Patch

Rejecting attachment 390790 [details] from commit-queue.

New failing tests:
imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events.html
Full output: https://webkit-queues.webkit.org/results/13322997
Comment 8 WebKit Commit Bot 2020-02-14 13:59:33 PST
Created attachment 390814 [details]
Archive of layout-test-results from webkit-cq-03 for mac-mojave

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-mojave  Platform: Mac OS X 10.14.6
Comment 9 Ben Nham 2020-02-14 14:43:42 PST
Comment on attachment 390790 [details]
Patch

Trying to push through cq again, since the test the cq failed this patch on is flaky and just got disabled: https://trac.webkit.org/changeset/256645/webkit
Comment 10 WebKit Commit Bot 2020-02-14 17:01:08 PST
Comment on attachment 390790 [details]
Patch

Clearing flags on attachment: 390790

Committed r256657: <https://trac.webkit.org/changeset/256657>
Comment 11 WebKit Commit Bot 2020-02-14 17:01:10 PST
All reviewed patches have been landed.  Closing bug.