Bug 207765 - [WPE] WPEQtView.h includes the uninstalled WPEQtViewBackend.h
Summary: [WPE] WPEQtView.h includes the uninstalled WPEQtViewBackend.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2020-02-14 07:37 PST by Alberto Garcia
Modified: 2020-02-14 08:43 PST (History)
2 users (show)

See Also:

Patch (1.65 KB, patch)
2020-02-14 08:00 PST, Alberto Garcia
pnormand: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2020-02-14 07:37:07 PST
When the Qt API is enabled then WPEQtView.h and WPEQtViewLoadRequest.h
are installed (see Source/WebKit/PlatformWPE.cmake)

However the former also includes WPEQtViewBackend.h, which is not

So we should either install that header, or forward-declare
WPEQtViewBackend in WPEQtView.h
Comment 1 Philippe Normand 2020-02-14 07:49:11 PST
Seeing m_backend is private in WPEQtView, perhaps a forward-declaration would be enough?
Comment 2 Alberto Garcia 2020-02-14 07:53:15 PST
I would expect that a forward declaration is enough, but I don't know if WPEQtViewBackend is supposed to be public at all.
Comment 3 Philippe Normand 2020-02-14 07:54:30 PST
The ViewBackend is meant to remain internal and shouldn't be exposed to app, IMHO :)
Comment 4 Alberto Garcia 2020-02-14 08:00:54 PST
Created attachment 390770 [details]
Comment 5 Philippe Normand 2020-02-14 08:28:51 PST
Comment on attachment 390770 [details]

Thanks, looks good. I'm just doing a local build to test, because the EWS doesn't support it.
Comment 6 Alberto Garcia 2020-02-14 08:43:38 PST
Committed r256612: <https://trac.webkit.org/changeset/256612>