Bug 207733 - MediaToolbox may not be available; check before calling MTOverrideShouldPlayHDRVideo()
Summary: MediaToolbox may not be available; check before calling MTOverrideShouldPlayH...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-13 17:21 PST by Jer Noble
Modified: 2020-02-13 19:48 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.56 KB, patch)
2020-02-13 17:22 PST, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-02-13 17:21:58 PST
MediaToolbox may not be available; check before calling MTOverrideShouldPlayHDRVideo()
Comment 1 Jer Noble 2020-02-13 17:22:15 PST
<rdar://problem/59441647>
Comment 2 Jer Noble 2020-02-13 17:22:59 PST
Created attachment 390709 [details]
Patch
Comment 3 Maciej Stachowiak 2020-02-13 19:02:30 PST
Comment on attachment 390709 [details]
Patch

r=me

Is there way to make a test for this?
Comment 4 Jer Noble 2020-02-13 19:25:14 PST
Not really. You’d have to literally delete MediaToolbox from the file system in order to induce this condition.
Comment 5 WebKit Commit Bot 2020-02-13 19:48:39 PST
Comment on attachment 390709 [details]
Patch

Clearing flags on attachment: 390709

Committed r256584: <https://trac.webkit.org/changeset/256584>
Comment 6 WebKit Commit Bot 2020-02-13 19:48:40 PST
All reviewed patches have been landed.  Closing bug.