Bug 207729 - [PlayStation] Make special udis86 C file handling only happen for Visual Studio
Summary: [PlayStation] Make special udis86 C file handling only happen for Visual Studio
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-13 16:37 PST by Stephan Szabo
Modified: 2020-02-13 18:25 PST (History)
13 users (show)

See Also:

Attachments
Patch (1.95 KB, patch)
2020-02-13 16:41 PST, Stephan Szabo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2020-02-13 16:37:50 PST 
For Visual Studio, we have a problem where the c++ standard flag gets set to C files (but Ninja does not add the flag). We now set the source file properties to set the language to CXX which makes Visual Studio building work, however breaks some ninja builds with the same error (now Ninja thinks it's C++ code so adds the flag, but then the compiler tries to compile it as C and fails).
Comment 1 Stephan Szabo 2020-02-13 16:41:16 PST 
Created attachment 390703 [details]
Patch
Comment 2 WebKit Commit Bot 2020-02-13 18:24:32 PST 
The commit-queue encountered the following flaky tests while processing attachment 390703 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2020-02-13 18:25:10 PST 
Comment on attachment 390703 [details]
Patch

Clearing flags on attachment: 390703

Committed r256579: <https://trac.webkit.org/changeset/256579>
Comment 4 WebKit Commit Bot 2020-02-13 18:25:12 PST 
All reviewed patches have been landed.  Closing bug.