For Visual Studio, we have a problem where the c++ standard flag gets set to C files (but Ninja does not add the flag). We now set the source file properties to set the language to CXX which makes Visual Studio building work, however breaks some ninja builds with the same error (now Ninja thinks it's C++ code so adds the flag, but then the compiler tries to compile it as C and fails).
Created attachment 390703 [details]
The commit-queue encountered the following flaky tests while processing attachment 390703 [details]:
editing/spelling/spellcheck-attribute.html bug 206178 (authors: email@example.com, firstname.lastname@example.org, and email@example.com)
The commit-queue is continuing to process your patch.
Comment on attachment 390703 [details]
Clearing flags on attachment: 390703
Committed r256579: <https://trac.webkit.org/changeset/256579>
All reviewed patches have been landed. Closing bug.