Bug 207688 – [WPE] Add support for rendering progress bars

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Carlos Garcia Campos]

.

[Carlos Garcia Campos]

Created attachment 390630 [details]
Patch

[Adrian Perez]

Comment on attachment 390630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390630&action=review

Just one small nit :]

> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:263
> +        fieldRect.setWidth(std::max<float>(2, fieldRect.width() / progressActivityBlocks));

Isn't two pixels a tad too narrow? Maybe it would make sense to
make it slightly wider, I think something around 5 to 6px would
be good.

[Adrian Perez]

FWIW, which other patches does this depend on? It would be nice
to have them listed in the “Depends on” field in the bug =)

[Carlos Garcia Campos]

(In reply to Adrian Perez from comment #2)
> Comment on attachment 390630 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=390630&action=review
> 
> Just one small nit :]
> 
> > Source/WebCore/platform/wpe/RenderThemeWPE.cpp:263
> > +        fieldRect.setWidth(std::max<float>(2, fieldRect.width() / progressActivityBlocks));
> 
> Isn't two pixels a tad too narrow? Maybe it would make sense to
> make it slightly wider, I think something around 5 to 6px would
> be good.

I don't think so, this is the small bar that moves left -> right -> left for indeterminate progress bars. Those 2 pixels are only used when the width of the progress bar is very small.

[Carlos Garcia Campos]

Created attachment 391037 [details]
Patch for landing

[Carlos Garcia Campos]

Committed r256824: <https://trac.webkit.org/changeset/256824>