Some IPC messages use IPC::Attachment to carry fence ports, we need to use the class MachPort instead.
Created attachment 409310 [details]
Comment on attachment 409310 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=409310&action=review
This patch looks good.
> + if (DrawingAreaProxy* drawingArea = m_page->drawingArea())
OK as-is. auto* could be used here too.
> + m_page->send(Messages::VideoFullscreenManager::SetVideoLayerFrameFenced(contextId, frame, fenceSendRight));
> +void WebPage::setTopContentInsetFenced(float contentInset, const WTF::MachSendRight& machSendRight)
OK as-is. Could be improved a tiny bit by taking by rvalue reference then need to patch up other places in this patch though. The param name sounds a bit ambiguous too and same comment for same param in WebProcess code.
> + m_drawingArea->addFence(machSendRight);
OK as-is. If ^^^ taken then could patch up addFence to take by rvalue reference and move into.
Committed r267599: <https://trac.webkit.org/changeset/267599>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 409310 [details].