Bug 207683 – Replace the usages of (IPC::Attachment fencePort) with IPC::MachPort

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Peng Liu]

Some IPC messages use IPC::Attachment to carry fence ports, we need to use the class MachPort instead.

[Peng Liu]

Created attachment 409310 [details]
Patch

[Daniel Bates]

Comment on attachment 409310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409310&action=review

This patch looks good.

> Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:795
> +    if (DrawingAreaProxy* drawingArea = m_page->drawingArea())

OK as-is. auto* could be used here too.

> Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:799
> +    m_page->send(Messages::VideoFullscreenManager::SetVideoLayerFrameFenced(contextId, frame, fenceSendRight));

OK as-is.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:3176
> +void WebPage::setTopContentInsetFenced(float contentInset, const WTF::MachSendRight& machSendRight)

OK as-is. Could be improved a tiny bit by taking by rvalue reference then need to patch up other places in this patch though. The param name sounds a bit ambiguous too and same comment for same param in WebProcess code.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:3178
> +    m_drawingArea->addFence(machSendRight);

OK as-is. If ^^^ taken then could patch up addFence to take by rvalue reference and move into.

[EWS]

Committed r267599: <https://trac.webkit.org/changeset/267599>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409310 [details].

[Radar WebKit Bug Importer]

<rdar://problem/69596514>