Bug 207681 - [LFC][IFC] LineCandidateContent can have only one float item
Summary: [LFC][IFC] LineCandidateContent can have only one float item
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-12 21:38 PST by zalan
Modified: 2020-02-13 08:22 PST (History)
6 users (show)

See Also:


Attachments
Patch (19.21 KB, patch)
2020-02-12 21:43 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (19.29 KB, patch)
2020-02-13 07:22 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-02-12 21:38:30 PST
There's always a soft wrap opportunity between float and text and float and float etc.
Comment 1 Radar WebKit Bug Importer 2020-02-12 21:38:54 PST
<rdar://problem/59413044>
Comment 2 zalan 2020-02-12 21:43:04 PST
Created attachment 390614 [details]
Patch
Comment 3 zalan 2020-02-13 06:39:22 PST
I should probably use Variant here.
Comment 4 zalan 2020-02-13 07:22:39 PST
Created attachment 390640 [details]
Patch
Comment 5 WebKit Commit Bot 2020-02-13 08:21:38 PST
The commit-queue encountered the following flaky tests while processing attachment 390640 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-02-13 08:22:15 PST
Comment on attachment 390640 [details]
Patch

Clearing flags on attachment: 390640

Committed r256507: <https://trac.webkit.org/changeset/256507>
Comment 7 WebKit Commit Bot 2020-02-13 08:22:17 PST
All reviewed patches have been landed.  Closing bug.