Bug 207670 - [LFC][IFC] Remove LineLayoutContext::m_partialTrailingTextItem
Summary: [LFC][IFC] Remove LineLayoutContext::m_partialTrailingTextItem
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-12 16:17 PST by zalan
Modified: 2020-02-12 18:47 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.58 KB, patch)
2020-02-12 16:20 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (3.58 KB, patch)
2020-02-12 16:50 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-02-12 16:17:22 PST
Now that LineBuilder is not holding a reference to these InlineItems anymore.
Comment 1 Radar WebKit Bug Importer 2020-02-12 16:17:54 PST
<rdar://problem/59405854>
Comment 2 zalan 2020-02-12 16:20:46 PST
Created attachment 390584 [details]
Patch
Comment 3 Antti Koivisto 2020-02-12 16:36:36 PST
Comment on attachment 390584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390584&action=review

> Source/WebCore/layout/inlineformatting/LineLayoutContext.h:-85
>      Optional<InlineTextItem> m_partialLeadingTextItem;
> -    Optional<InlineTextItem> m_partialTrailingTextItem;

Why not both?
Comment 4 zalan 2020-02-12 16:48:33 PST
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 390584 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=390584&action=review
> 
> > Source/WebCore/layout/inlineformatting/LineLayoutContext.h:-85
> >      Optional<InlineTextItem> m_partialLeadingTextItem;
> > -    Optional<InlineTextItem> m_partialTrailingTextItem;
> 
> Why not both?
The partial leading needs a bit more work. LineBreaker can actually hold onto it as the last wrapping opportunity (this is the rare revert case). I am addressing it in a separate patch.
Comment 5 zalan 2020-02-12 16:50:49 PST
Created attachment 390591 [details]
Patch
Comment 6 WebKit Commit Bot 2020-02-12 18:47:07 PST
Comment on attachment 390591 [details]
Patch

Clearing flags on attachment: 390591

Committed r256499: <https://trac.webkit.org/changeset/256499>
Comment 7 WebKit Commit Bot 2020-02-12 18:47:09 PST
All reviewed patches have been landed.  Closing bug.