Bug 207668 - [Mac wk2 ] fast/dom/attr_dead_doc.html is flaky failing.
Summary: [Mac wk2 ] fast/dom/attr_dead_doc.html is flaky failing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Mac macOS 10.15
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-12 15:44 PST by Jason Lawrence
Modified: 2020-03-13 13:19 PDT (History)
9 users (show)

See Also:


Attachments
Patch (4.29 KB, patch)
2020-03-13 12:01 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Lawrence 2020-02-12 15:44:22 PST
fast/dom/attr_dead_doc.html

Description:
This test is flaky failing on Mac.
I see the same diff back to r253950, the flaky failures go back to all visible history.

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fdom%2Fattr_dead_doc.html&platform=mac&limit=50000

Diff:
layer at (0,0) size 800x600
  RenderView at (0,0) size 800x600
layer at (0,0) size 800x600
  RenderBlock {HTML} at (0,0) size 800x600
    RenderBody {BODY} at (8,8) size 784x584
      RenderIFrame {IFRAME} at (0,0) size 304x154 [border: (2px inset #000000)]
        layer at (0,0) size 300x150
          RenderView at (0,0) size 300x150
        layer at (0,0) size 300x150
          RenderBlock {HTML} at (0,0) size 300x150
            RenderBody {BODY} at (8,8) size 284x134
              RenderImage {IMG} at (0,0) size 80x64
              RenderText {#text} at (0,0) size 0x0
      RenderText {#text} at (0,0) size 0x0
Comment 1 Radar WebKit Bug Importer 2020-02-12 15:44:44 PST
<rdar://problem/59404606>
Comment 2 Jason Lawrence 2020-02-12 15:49:11 PST
I have marked this test as failing while the issue is investigated.
https://trac.webkit.org/changeset/256488/webkit
Comment 3 Alexey Proskuryakov 2020-02-16 18:29:50 PST
@@ -9,4 +9,6 @@
         layer at (0,0) size 300x150
           RenderBlock {HTML} at (0,0) size 300x150
             RenderBody {BODY} at (8,8) size 284x134
+              RenderImage {IMG} at (0,0) size 80x64
+              RenderText {#text} at (0,0) size 0x0
       RenderText {#text} at (0,0) size 0x0
Comment 4 Chris Dumez 2020-03-13 11:45:47 PDT
Test seems to be relying on a 100ms timer...
Comment 5 Chris Dumez 2020-03-13 12:01:17 PDT
Created attachment 393515 [details]
Patch
Comment 6 Geoffrey Garen 2020-03-13 12:04:58 PDT
Comment on attachment 393515 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2020-03-13 13:19:21 PDT
Comment on attachment 393515 [details]
Patch

Clearing flags on attachment: 393515

Committed r258423: <https://trac.webkit.org/changeset/258423>
Comment 8 WebKit Commit Bot 2020-03-13 13:19:23 PDT
All reviewed patches have been landed.  Closing bug.