Bug 207662 - run-javascriptcore-tests: Allow insecure requests on upload
Summary: run-javascriptcore-tests: Allow insecure requests on upload
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-12 13:50 PST by Jonathan Bedard
Modified: 2020-02-12 16:35 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.40 KB, patch)
2020-02-12 13:55 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (1.42 KB, patch)
2020-02-12 15:31 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (1.42 KB, patch)
2020-02-12 15:51 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-02-12 13:50:05 PST 
We need to pass --insecure to curl since some versions of Windows don't have the certificate chain for results.webkit.org. See: https://build.webkit.org/builders/Apple%20Win%2010%20Debug%20%28Tests%29/builds/3419/steps/jscore-test/logs/stdio.
Comment 1 Jonathan Bedard 2020-02-12 13:55:40 PST 
Created attachment 390556 [details]
Patch
Comment 2 Aakash Jain 2020-02-12 14:40:24 PST 
rs=me
Comment 3 Jonathan Bedard 2020-02-12 15:31:31 PST 
Created attachment 390570 [details]
Patch
Comment 4 Jonathan Bedard 2020-02-12 15:51:38 PST 
Created attachment 390574 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2020-02-12 16:34:16 PST 
Comment on attachment 390574 [details]
Patch for landing

Clearing flags on attachment: 390574

Committed r256492: <https://trac.webkit.org/changeset/256492>
Comment 6 WebKit Commit Bot 2020-02-12 16:34:18 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-02-12 16:35:14 PST 
<rdar://problem/59406458>