Bug 207661 – Do not call whenReady callbacks in case of network process crash

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

Make sure to not create a ServiceWorkerRegistration when calling whenReady callback in case of network process crash

[youenn fablet]

Created attachment 390555 [details]
Patch

[youenn fablet]

Created attachment 390590 [details]
Patch

[youenn fablet]

Ping review.

[Chris Dumez]

Comment on attachment 390590 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390590&action=review

> Source/WebCore/workers/service/WorkerSWClientConnection.cpp:-57
> -    auto whenRegistrationReadyRequests = WTFMove(m_whenRegistrationReadyRequests);

I believe this means the ready promise will never get resolved in this case. Which is unfortunate.

[youenn fablet]

(In reply to Chris Dumez from comment #4)
> Comment on attachment 390590 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=390590&action=review
> 
> > Source/WebCore/workers/service/WorkerSWClientConnection.cpp:-57
> > -    auto whenRegistrationReadyRequests = WTFMove(m_whenRegistrationReadyRequests);
> 
> I believe this means the ready promise will never get resolved in this case.
> Which is unfortunate.

That is why we are using a Function and not a CompletionHandler.
There is no guarantee that it will be ready anytime soon.
With or without this patch, if the network process is crashing, we are in a bad position with regards to the ready promise.

I will update the patch to clear the function handler.

[youenn fablet]

Created attachment 390981 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 390981 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 390981 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 390981 [details]
Patch

Clearing flags on attachment: 390981

Committed r256805: <https://trac.webkit.org/changeset/256805>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59535599>