Bug 207656 - [Curl] Force HTTP/1.1 for WebSocket connection
Summary: [Curl] Force HTTP/1.1 for WebSocket connection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-12 12:39 PST by Basuke Suzuki
Modified: 2020-02-13 18:54 PST (History)
8 users (show)

See Also:

Attachments
PATCH (1.33 KB, patch)
2020-02-12 12:47 PST, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2020-02-12 12:39:18 PST 
Curl layer currently doesn't support WebSocket over HTTP/2. Just disable HTTP/2 for now.
Comment 1 Basuke Suzuki 2020-02-12 12:39:42 PST 
For future reference, https://tools.ietf.org/html/rfc8441
Comment 2 Basuke Suzuki 2020-02-12 12:40:59 PST 
Here's Mozilla implementation record: https://bugzilla.mozilla.org/show_bug.cgi?id=1434137
Comment 3 Basuke Suzuki 2020-02-12 12:47:55 PST 
Created attachment 390548 [details]
PATCH
Comment 4 WebKit Commit Bot 2020-02-12 15:09:40 PST 
The commit-queue encountered the following flaky tests while processing attachment 390548 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2020-02-12 15:10:02 PST 
The commit-queue encountered the following flaky tests while processing attachment 390548 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-02-12 15:47:02 PST 
Comment on attachment 390548 [details]
PATCH

Clearing flags on attachment: 390548

Committed r256487: <https://trac.webkit.org/changeset/256487>
Comment 7 WebKit Commit Bot 2020-02-12 15:47:04 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-02-12 15:48:14 PST 
<rdar://problem/59404767>
Comment 9 Fujii Hironori 2020-02-13 18:54:20 PST 
I confirmed the latest WinCairo works fine. It was so annoying. Thanks you very much!

https://ews-build.webkit.org/
https://libwebsockets.org/testserver/