Bug 207644 - Update WPT tests for encoding
Summary: Update WPT tests for encoding
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-12 10:30 PST by Carlos Alberto Lopez Perez
Modified: 2020-02-17 07:32 PST (History)
8 users (show)

See Also:

Attachments
Patch (29.58 MB, patch)
2020-02-12 10:40 PST, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Patch (30.99 MB, patch)
2020-02-13 10:32 PST, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Patch (29.90 MB, patch)
2020-02-13 17:25 PST, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Patch (30.91 MB, patch)
2020-02-13 18:34 PST, Carlos Alberto Lopez Perez 		youennf: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2020-02-12 10:30:59 PST 
Update imported WPT tests for encoding/ to ToT
Comment 1 Carlos Alberto Lopez Perez 2020-02-12 10:40:05 PST 
Created attachment 390535 [details]
Patch

Test EWS
Comment 2 Carlos Alberto Lopez Perez 2020-02-13 10:32:35 PST 
Created attachment 390666 [details]
Patch

Test EWS
Comment 3 Carlos Alberto Lopez Perez 2020-02-13 16:58:09 PST 
It seems the test importer broke the tests imported/w3c/web-platform-tests/encoding/eof-utf-8-one.html imported/w3c/web-platform-tests/encoding/eof-utf-8-three.html imported/w3c/web-platform-tests/encoding/eof-utf-8-two.html due to (just reported) bug 207731

I will workaround that by manually copying those tests from wpt.
I will seize and also remove the reftest.list from this directory and move the expectations for those tests to -expected.html. see bug 203783
Comment 4 Carlos Alberto Lopez Perez 2020-02-13 17:25:57 PST 
Created attachment 390711 [details]
Patch

Test EWS again. Hopefully green now
Comment 5 Carlos Alberto Lopez Perez 2020-02-13 18:28:04 PST 
More fun stuff, the rewriter does some strange things with some test resources breaking several subtests of two test files. See bug 207736
Comment 6 Carlos Alberto Lopez Perez 2020-02-13 18:34:59 PST 
Created attachment 390714 [details]
Patch
Comment 7 Carlos Alberto Lopez Perez 2020-02-14 03:18:05 PST 
All EWS green, asking for review now.
Comment 8 Carlos Alberto Lopez Perez 2020-02-14 04:05:31 PST 
jesus.. the patch is so big (30MB of text only) that I can't set "r?" on the review console :(

Please, just comment "r=me" here and i will take that as an r+
Comment 9 Carlos Alberto Lopez Perez 2020-02-14 04:30:10 PST 
(In reply to Carlos Alberto Lopez Perez from comment #8)
> jesus.. the patch is so big (30MB of text only) that I can't set "r?" on the
> review console :(
> 
> Please, just comment "r=me" here and i will take that as an r+

It seems the JS from code-review.js has a fatal error with this patch, reported in bug 207755
Comment 10 youenn fablet 2020-02-14 09:24:27 PST 
Comment on attachment 390714 [details]
Patch

rs=me
Comment 11 Carlos Alberto Lopez Perez 2020-02-17 07:30:37 PST 
Committed r256730: <https://trac.webkit.org/changeset/256730>
Comment 12 Radar WebKit Bug Importer 2020-02-17 07:32:03 PST 
<rdar://problem/59510100>