RESOLVED FIXED Bug 207644
Update WPT tests for encoding 
https://bugs.webkit.org/show_bug.cgi?id=207644
Summary Update WPT tests for encoding
Carlos Alberto Lopez Perez
Reported 2020-02-12 10:30:59 PST
Update imported WPT tests for encoding/ to ToT
Attachments
Patch (29.58 MB, patch)
2020-02-12 10:40 PST, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (30.99 MB, patch)
2020-02-13 10:32 PST, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (29.90 MB, patch)
2020-02-13 17:25 PST, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (30.91 MB, patch)
2020-02-13 18:34 PST, Carlos Alberto Lopez Perez 		youennf: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2020-02-12 10:40:05 PST
Created attachment 390535 [details] Patch Test EWS
Carlos Alberto Lopez Perez
Comment 2 2020-02-13 10:32:35 PST
Created attachment 390666 [details] Patch Test EWS
Carlos Alberto Lopez Perez
Comment 3 2020-02-13 16:58:09 PST
It seems the test importer broke the tests imported/w3c/web-platform-tests/encoding/eof-utf-8-one.html imported/w3c/web-platform-tests/encoding/eof-utf-8-three.html imported/w3c/web-platform-tests/encoding/eof-utf-8-two.html due to (just reported) bug 207731 I will workaround that by manually copying those tests from wpt. I will seize and also remove the reftest.list from this directory and move the expectations for those tests to -expected.html. see bug 203783
Carlos Alberto Lopez Perez
Comment 4 2020-02-13 17:25:57 PST
Created attachment 390711 [details] Patch Test EWS again. Hopefully green now
Carlos Alberto Lopez Perez
Comment 5 2020-02-13 18:28:04 PST
More fun stuff, the rewriter does some strange things with some test resources breaking several subtests of two test files. See bug 207736
Carlos Alberto Lopez Perez
Comment 6 2020-02-13 18:34:59 PST
Created attachment 390714 [details] Patch
Carlos Alberto Lopez Perez
Comment 7 2020-02-14 03:18:05 PST
All EWS green, asking for review now.
Carlos Alberto Lopez Perez
Comment 8 2020-02-14 04:05:31 PST
jesus.. the patch is so big (30MB of text only) that I can't set "r?" on the review console :( Please, just comment "r=me" here and i will take that as an r+
Carlos Alberto Lopez Perez
Comment 9 2020-02-14 04:30:10 PST
(In reply to Carlos Alberto Lopez Perez from comment #8) > jesus.. the patch is so big (30MB of text only) that I can't set "r?" on the > review console :( > > Please, just comment "r=me" here and i will take that as an r+ It seems the JS from code-review.js has a fatal error with this patch, reported in bug 207755
youenn fablet
Comment 10 2020-02-14 09:24:27 PST
Comment on attachment 390714 [details] Patch rs=me
Carlos Alberto Lopez Perez
Comment 11 2020-02-17 07:30:37 PST
Committed r256730: <https://trac.webkit.org/changeset/256730>
Radar WebKit Bug Importer
Comment 12 2020-02-17 07:32:03 PST
<rdar://problem/59510100>
Note You need to log in before you can comment on or make changes to this bug.