<rdar://problem/59212993>
Created attachment 390493 [details] Patch
Comment on attachment 390493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390493&action=review > Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:184 > + if ([NSStringFromClass(view.class) isEqualToString:@"_UIScrollViewScrollIndicator"] && [view.superview isKindOfClass:WKChildScrollView.class]) { NSStringFromClass every time is probably not a great plan. Maybe look up the class from string once, keep it, and use isKindOfClass? Or at least flip the conditions?
Comment on attachment 390493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390493&action=review >> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:184 >> + if ([NSStringFromClass(view.class) isEqualToString:@"_UIScrollViewScrollIndicator"] && [view.superview isKindOfClass:WKChildScrollView.class]) { > > NSStringFromClass every time is probably not a great plan. Maybe look up the class from string once, keep it, and use isKindOfClass? > > Or at least flip the conditions? Good catch! I'll cache the class in a static helper (using dispatch_once) and pass it into -isKindOfClass.
Created attachment 390494 [details] Patch
The commit-queue encountered the following flaky tests while processing attachment 390494 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
Comment on attachment 390494 [details] Patch Clearing flags on attachment: 390494 Committed r256433: <https://trac.webkit.org/changeset/256433>
All reviewed patches have been landed. Closing bug.