Bug 207612 - [LFC][IFC] Do not create Display::Boxes for anonymous inline text boxes
Summary: [LFC][IFC] Do not create Display::Boxes for anonymous inline text boxes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-11 20:24 PST by zalan
Modified: 2020-02-12 12:01 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.36 KB, patch)
2020-02-11 20:27 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (4.46 KB, patch)
2020-02-12 11:18 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-02-11 20:24:30 PST 
<div>foobar</div> [foobar] needs only a Display::Run but no Display::Box.
Comment 1 Radar WebKit Bug Importer 2020-02-11 20:24:46 PST 
<rdar://problem/59374909>
Comment 2 zalan 2020-02-11 20:27:18 PST 
Created attachment 390488 [details]
Patch
Comment 3 Antti Koivisto 2020-02-12 08:30:25 PST 
Comment on attachment 390488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390488&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:491
>          if (lineRun.isLineBreak()) {
> +            auto& displayBox = formattingState.displayBox(layoutBox);

Could we avoid this too?
Comment 4 zalan 2020-02-12 11:18:13 PST 
Created attachment 390540 [details]
Patch
Comment 5 WebKit Commit Bot 2020-02-12 12:01:19 PST 
Comment on attachment 390540 [details]
Patch

Clearing flags on attachment: 390540

Committed r256466: <https://trac.webkit.org/changeset/256466>
Comment 6 WebKit Commit Bot 2020-02-12 12:01:21 PST 
All reviewed patches have been landed.  Closing bug.