Bug 207601 – Fix highlight text decorations to work with all decoration types and colors

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Fix highlight text decorations to work with all decoration types and colors

[Megan Gardner]

Created attachment 390469 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/59374153>

[Dean Jackson]

Comment on attachment 390469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390469&action=review

> Source/WebCore/ChangeLog:11
> +        Extended http/wpt/css/css-highlight-api/highlight-text-decorations.html.

What are our plans to contribute this back to WPT?

> Source/WebCore/rendering/TextDecorationPainter.cpp:377
> +    Color result = style.visitedDependentColorWithColorFilter(CSSPropertyTextDecorationColor);

auto?

[Simon Fraser (smfr)]

Comment on attachment 390469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390469&action=review

> LayoutTests/http/wpt/css/css-highlight-api/highlight-text-decorations-expected.html:10
> +        text-decoration: underline;
> +        text-decoration-color: red;

Bad indentation or tabs.

[Megan Gardner]

Dean, we plan on pushing them back at some point in time, but probably not until we fix the issues that require the obscurers.

[Megan Gardner]

Created attachment 390530 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 390530 [details]
Patch for landing

Clearing flags on attachment: 390530

Committed r256451: <https://trac.webkit.org/changeset/256451>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.