Bug 207601 - Fix highlight text decorations to work with all decoration types and colors
Summary: Fix highlight text decorations to work with all decoration types and colors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-11 16:46 PST by Megan Gardner
Modified: 2020-02-12 10:40 PST (History)
11 users (show)

See Also:

Attachments
Patch (11.73 KB, patch)
2020-02-11 16:56 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (11.67 KB, patch)
2020-02-12 09:48 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2020-02-11 16:46:55 PST 
Fix highlight text decorations to work with all decoration types and colors
Comment 1 Megan Gardner 2020-02-11 16:56:42 PST 
Created attachment 390469 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-02-11 19:42:18 PST 
<rdar://problem/59374153>
Comment 3 Dean Jackson 2020-02-12 09:38:40 PST 
Comment on attachment 390469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390469&action=review

> Source/WebCore/ChangeLog:11
> +        Extended http/wpt/css/css-highlight-api/highlight-text-decorations.html.

What are our plans to contribute this back to WPT?

> Source/WebCore/rendering/TextDecorationPainter.cpp:377
> +    Color result = style.visitedDependentColorWithColorFilter(CSSPropertyTextDecorationColor);

auto?
Comment 4 Simon Fraser (smfr) 2020-02-12 09:40:06 PST 
Comment on attachment 390469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390469&action=review

> LayoutTests/http/wpt/css/css-highlight-api/highlight-text-decorations-expected.html:10
> +        text-decoration: underline;
> +        text-decoration-color: red;

Bad indentation or tabs.
Comment 5 Megan Gardner 2020-02-12 09:46:59 PST 
Dean, we plan on pushing them back at some point in time, but probably not until we fix the issues that require the obscurers.
Comment 6 Megan Gardner 2020-02-12 09:48:54 PST 
Created attachment 390530 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2020-02-12 10:40:28 PST 
Comment on attachment 390530 [details]
Patch for landing

Clearing flags on attachment: 390530

Committed r256451: <https://trac.webkit.org/changeset/256451>
Comment 8 WebKit Commit Bot 2020-02-12 10:40:30 PST 
All reviewed patches have been landed.  Closing bug.