Bug 207598 - Allow use of proxies in MiniBrowser
Summary: Allow use of proxies in MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-11 16:14 PST by Ben Nham
Modified: 2020-02-19 18:29 PST (History)
7 users (show)

See Also:

Attachments
Patch (6.48 KB, patch)
2020-02-11 16:18 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Patch (6.86 KB, patch)
2020-02-11 20:01 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2020-02-11 16:14:37 PST 
For testing purposes, we allow Safari to use a custom HTTP/HTTPS proxy passed through command line arguments. MiniBrowser should also be able to do this.
Comment 1 Radar WebKit Bug Importer 2020-02-11 16:15:15 PST 
<rdar://problem/59368527>
Comment 2 Ben Nham 2020-02-11 16:18:19 PST 
Created attachment 390458 [details]
Patch
Comment 3 Ben Nham 2020-02-11 20:01:48 PST 
Created attachment 390486 [details]
Patch
Comment 4 WebKit Commit Bot 2020-02-13 11:47:35 PST 
Comment on attachment 390486 [details]
Patch

Clearing flags on attachment: 390486

Committed r256530: <https://trac.webkit.org/changeset/256530>
Comment 5 WebKit Commit Bot 2020-02-13 11:47:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Alex Christensen 2020-02-13 15:32:10 PST 
Comment on attachment 390486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390486&action=review

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:386
>              parameters.defaultDataStoreParameters.networkSessionParameters.httpProxy = URL(URL(), [defaults stringForKey:(NSString *)WebKit2HTTPProxyDefaultsKey]);

This patch is good, but we should be pushing Safari and MiniBrowser towards using SPI when they want proxies rather than checking in defaults ourselves.
Comment 7 Sam Weinig 2020-02-19 18:29:30 PST 
Why are we special casing these apps? Seems like what a preference they enable or entitlements are for if we want to limit this for some reason.