Bug 207597 - ANGLE has unused bison and glmark2 code
Summary: ANGLE has unused bison and glmark2 code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-11 16:13 PST by Dean Jackson
Modified: 2020-02-12 09:34 PST (History)
5 users (show)

See Also:


Attachments
Patch (727.12 KB, patch)
2020-02-11 16:16 PST, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (727.07 KB, patch)
2020-02-11 16:26 PST, Dean Jackson
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2020-02-11 16:13:14 PST
ANGLE fails fatal gpl2_source_code and gpl3_source_code verifiers during build
Comment 1 Dean Jackson 2020-02-11 16:13:43 PST
rdar://59361460
Comment 2 Dean Jackson 2020-02-11 16:16:04 PST
Created attachment 390457 [details]
Patch
Comment 3 Build Bot 2020-02-11 16:17:25 PST
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Dean Jackson 2020-02-11 16:26:47 PST
Created attachment 390460 [details]
Patch
Comment 5 Maciej Stachowiak 2020-02-11 16:27:48 PST
Comment on attachment 390460 [details]
Patch

glmark’s README.angle says GPLv3, bnut the individual files removed in this patch have a BSD license header. What's up with that? Is it just the README that's wrong?

r=me
Comment 6 Dean Jackson 2020-02-12 09:34:11 PST
Committed r256443: <https://trac.webkit.org/changeset/256443>