Bug 207581 – Support event notifications in IsolatedTree mode.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andres Gonzalez]

Support event notifications in IsolatedTree mode.

[Andres Gonzalez]

Created attachment 390420 [details]
Patch

[chris fleizach]

Comment on attachment 390420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390420&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:3131
> +        tree->removeNode(object->objectID());

is it ok to removeNode here directly, or do we need to append this to the node changes?

> Source/WebCore/accessibility/AXObjectCache.cpp:3139
> +    };

this semi-colon after this line seems not needed

> Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:37
> +    [wrapper attachIsolatedObject:(AXCoreObject*)this];

is this cast necessary?
(AXCoreObject*)this];

[Andres Gonzalez]

Created attachment 390510 [details]
Patch

[Andres Gonzalez]

(In reply to chris fleizach from comment #2)
> Comment on attachment 390420 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=390420&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:3131
> > +        tree->removeNode(object->objectID());
> 
> is it ok to removeNode here directly, or do we need to append this to the
> node changes?

AXIsolatedTree::removeNode appends the AXID to the m_pendingRemovals under lock, which will be applied on the next call to applyPendingChanges on the AX thread.
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:3139
> > +    };
> 
> this semi-colon after this line seems not needed

Fixed.
> 
> > Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:37
> > +    [wrapper attachIsolatedObject:(AXCoreObject*)this];
> 
> is this cast necessary?
> (AXCoreObject*)this];

Fixed.

[chris fleizach]

Comment on attachment 390510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390510&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:3139
> +    default: {

{ } for default are unnecessary here since there's no code inside

[Andres Gonzalez]

(In reply to chris fleizach from comment #5)
> Comment on attachment 390510 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=390510&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:3139
> > +    default: {
> 
> { } for default are unnecessary here since there's no code inside

It is needed, otherwise you get:

./accessibility/AXObjectCache.cpp:3127:13: error: 30 enumeration values not handled in switch: 'AXActiveDescendantChanged', 'AXAutocorrectionOccured', 'AXCurrentChanged'... [-Werror,-Wswitch]
    switch (notification) {
            ^
./accessibility/AXObjectCache.cpp:3127:13: note: add missing switch cases
    switch (notification) {
            ^
1 error generated.

[Andres Gonzalez]

Created attachment 390525 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 390525 [details]
Patch

Clearing flags on attachment: 390525

Committed r256442: <https://trac.webkit.org/changeset/256442>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59389335>

[Andres Gonzalez]

*** Bug 206596 has been marked as a duplicate of this bug. ***