Bug 207575 - Should not allow zooming to reveal focused element when suppressing selection assistant
Summary: Should not allow zooming to reveal focused element when suppressing selection...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 13
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-11 12:49 PST by Daniel Bates
Modified: 2020-02-11 14:58 PST (History)
2 users (show)

See Also:

Attachments
Test case (503 bytes, text/html)
2020-02-11 14:43 PST, Daniel Bates 		no flags Details
Patch (2.66 KB, patch)
2020-02-11 14:49 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (2.67 KB, patch)
2020-02-11 14:49 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (2.66 KB, patch)
2020-02-11 14:53 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-02-11 12:49:26 PST 
At the time of writing it always makes sense to forbid zooming to reveal the focused element when the selection assistant is suppressed.
Comment 1 Daniel Bates 2020-02-11 13:07:37 PST 
Steps to reproduce:

1. Visit <data:text/html,<div contenteditable="true" style="height: 500px; width: 500px; border: 1px solid black"><span contenteditable="false"><a href="http://www.apple.com">Apple</a></span></div>>

2. Scroll and zoom the page such that "Apple" is partially offscreen, leave just enough on screen to tap-and-hold it.

3. Tap-and-hold on "Apple" to show a preview.

Then the page will scroll and zoom the content.
Comment 2 Daniel Bates 2020-02-11 14:43:58 PST 
Created attachment 390428 [details]
Test case

Test case. Depends on Ahem.ttf being in the same directory as the test. Tap and hold on the purple square.

This file can be used to write a future API test. I tried writing an API test, but WebKit uses UIKit IPI, -previewClickInteraction, this IPI is not in my SDK. So, I get "-[_UIClickPresentationInteraction previewClickInteraction]: unrecognized selector sent to instance 0x7f9a8a631bb0" messages.
Comment 3 Daniel Bates 2020-02-11 14:48:17 PST 
Blocked from writing a test because of <rdar://problem/59364638>.
Comment 4 Daniel Bates 2020-02-11 14:49:01 PST 
Created attachment 390432 [details]
Patch
Comment 5 Daniel Bates 2020-02-11 14:49:51 PST 
Created attachment 390433 [details]
Patch
Comment 6 Daniel Bates 2020-02-11 14:53:40 PST 
Created attachment 390441 [details]
Patch
Comment 7 Daniel Bates 2020-02-11 14:54:23 PST 
Thank you!
Comment 8 Daniel Bates 2020-02-11 14:57:43 PST 
Comment on attachment 390441 [details]
Patch

Clearing flags on attachment: 390441

Committed r256378: <https://trac.webkit.org/changeset/256378>
Comment 9 Daniel Bates 2020-02-11 14:57:45 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2020-02-11 14:58:14 PST 
<rdar://problem/59365183>