Bug 207565 - WebDriver: return invalidSessionID exception if the WebProcess doesn't respond (crashes)
Summary: WebDriver: return invalidSessionID exception if the WebProcess doesn't respon...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-11 11:02 PST by Carlos Alberto Lopez Perez
Modified: 2020-02-12 05:17 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.51 KB, patch)
2020-02-11 11:08 PST, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2020-02-11 11:02:18 PST 
One method the WPT runner uses to detect a crash inside the browser its to check if WebDriver continues to respond to a simple property get over the connection like current_window_handle

If an exception its returned then its assumed the browser has crashed and WebDriver its restarted

Currently the WebKitGTK webdriver hangs instead of returning an exception.

The Chrome WebDriver returns an InvalidSessionID message in case of crash with the error code "session deleted because of page crash"

We can do something similar for WebKitGTK WebDriver
Comment 1 Carlos Alberto Lopez Perez 2020-02-11 11:08:47 PST 
Created attachment 390394 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2020-02-12 05:16:09 PST 
Comment on attachment 390394 [details]
Patch

Clearing flags on attachment: 390394

Committed r256430: <https://trac.webkit.org/changeset/256430>
Comment 3 Carlos Alberto Lopez Perez 2020-02-12 05:16:13 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-02-12 05:17:14 PST 
<rdar://problem/59383477>