Bug 207537 - WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
Summary: WebSWServerConnection::registerServiceWorkerClient is not sending IPC message...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 207594
Blocks:
  Show dependency tree / graph
 
Reported: 2020-02-11 05:50 PST by youenn fablet
Modified: 2020-02-12 07:32 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.90 KB, patch)
2020-02-11 05:53 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (5.26 KB, patch)
2020-02-11 19:29 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-02-11 05:50:23 PST 
WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
Comment 1 youenn fablet 2020-02-11 05:52:25 PST 
<rdar://problem/58974747>
Comment 2 youenn fablet 2020-02-11 05:53:12 PST 
Created attachment 390355 [details]
Patch
Comment 3 WebKit Commit Bot 2020-02-11 09:57:21 PST 
Comment on attachment 390355 [details]
Patch

Clearing flags on attachment: 390355

Committed r256314: <https://trac.webkit.org/changeset/256314>
Comment 4 WebKit Commit Bot 2020-02-11 09:57:23 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2020-02-11 15:46:41 PST 
Re-opened since this is blocked by bug 207594
Comment 6 youenn fablet 2020-02-11 17:42:30 PST 
Issue with the test is that the assertion set for testing is overriden from 3 to 1 by the process throttler when didConnect is called.
I will change the test to start with background and then go foreground.
Comment 7 youenn fablet 2020-02-11 19:29:57 PST 
Created attachment 390482 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2020-02-12 07:32:19 PST 
The commit-queue encountered the following flaky tests while processing attachment 390482 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2020-02-12 07:32:55 PST 
Comment on attachment 390482 [details]
Patch for landing

Clearing flags on attachment: 390482

Committed r256432: <https://trac.webkit.org/changeset/256432>
Comment 10 WebKit Commit Bot 2020-02-12 07:32:57 PST 
All reviewed patches have been landed.  Closing bug.